Json_Encode php last comma

Question

For a school project I have to display database data as a valid json file.

            $result = mysqli_query($mysqli, "SELECT * FROM `csvdata`");

            echo "{ \"films\" : [";
            while ($row = mysqli_fetch_array($result)) {
                $jsonResult = json_encode($row);
                echo $jsonResult;
                echo ",";   
            }
                echo "]}";

The output i get is:

{
    "films": [
        {
            "0": "Man on fire",
            "titel": "Man on fire",
            "1": "Actie",
            "genre": "Actie"
        },
        {
            "0": "Dumb and Dumberer",
            "titel": "Dumb and Dumberer",
            "1": "Comedy",
            "genre": "Comedy"
        },
        {
            "0": "DefQon 2014",
            "titel": "DefQon 2014",
            "1": "Muziek",
            "genre": "Muziek"
        },

    ]
}

Now my question is, how do I remove the last comma, I cannot find that. And all data tells the data 2 times, I also don't know how to avoid this.

AFAIK, the trailing comma in JSON arrays is ok, you should not care about it. — Necto
– Necto, Commented Jan 11, 2015 at 18:37
Collect the entire result in one PHP array, and then json_encode it all at once after it's built. — user1233508
– user1233508, Commented Jan 11, 2015 at 18:40
@Necto No, it's not OK. It is invalid and most libraries will fail on it - including PHP's json_decode. — ceejayoz
– ceejayoz, Commented Jan 11, 2015 at 18:42

ceejayoz · Accepted Answer · 2015-01-11 18:41:06Z

2

Let json_encode handle the entire thing - build one array of data, and use json_encode on that.

$result = mysqli_query($mysqli, "SELECT * FROM `csvdata`");

$response = array();
$response['films'] = array();

while ($row = mysqli_fetch_array($result)) {
  $response['films'][] = $row;
}

echo json_encode($response);

answered Jan 11, 2015 at 18:41

ceejayoz

181k42 gold badges311 silver badges382 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Patrick Over a year ago

Great, this helped!:) Now i just have the double data in, i don't know where it comes from. It is not in my database.. the "0" data and the "1" data

ceejayoz Over a year ago

@Patrick Use mysqli_fetch_assoc instead of mysqli_fetch_array to fix that or do mysqli_fetch_array($result, MYSQLI_ASSOC). The default behaviour is MYSQLI_BOTH which spits out both an associative and a numeric array.

Evert · Accepted Answer · 2015-01-11 18:37:33Z

0

A good way to do this, is to not place a comma after writing every record, but instead before every record.

Then all you have to do, is add an if statement that doesn't output the comma for the very first row.

answered Jan 11, 2015 at 18:37

Evert

101k18 gold badges136 silver badges221 bronze badges

Collectives™ on Stack Overflow

Json_Encode php last comma

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related