Array is Returning NULL

Question

My piece of code..

package com.xchanging.selenium.utility;

import java.io.IOException;
import java.util.LinkedHashMap;

import org.apache.commons.lang3.ArrayUtils;

public class DataProviderConvertor extends ReadExcel {

    public static Object[][] convertData(String sheetName, String testCaseName)
            throws IOException {

        LinkedHashMap<String, String> table = ReadExcel.getData(sheetName,
                testCaseName);
        String[] myStringArray = new String[table.size()];
        for (String key : table.values()) {
            System.out.println("Keyvalues " + key.toString());
            String value = key.toString();
            ArrayUtils.add(myStringArray, value);
        }
        System.out.println("1st Index: " myStringArray[0]);
    }
  }

It is returning

Keyvalues Y
Keyvalues ie
Keyvalues QC 
Keyvalues Yes
Keyvalues Rework Checklist Comments
Keyvalues Yes
Keyvalues MRI Updated Comments


1st Index: null

I am expecting 6 elements in this array but all are returning NULL.. Why it is not returning the expected values..??

where are you returning btw

shikjohari
– shikjohari

2015-01-12 06:47:17 +00:00
Commented Jan 12, 2015 at 6:47 — shikjohari
– shikjohari, Commented Jan 12, 2015 at 6:47
@ChanGan just two changes required, code is fine

Ankur Singhal
– Ankur Singhal

2015-01-12 07:06:49 +00:00
Commented Jan 12, 2015 at 7:06 — Ankur Singhal
– Ankur Singhal, Commented Jan 12, 2015 at 7:06

user2649908 · Accepted Answer · 2015-01-12 06:54:18Z

2

How about much simpler way.

public static Object[][] convertData(String sheetName, String testCaseName)
        throws IOException {

    LinkedHashMap<String, String> table = ReadExcel.getData(sheetName,
            testCaseName);

    String[] myStringArray = table.values().toArray( new String[ 0 ] );

    System.out.println("1st Index: " + myStringArray[0]);
}

answered Jan 12, 2015 at 6:54

user2649908

5757 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

atish shimpi · Accepted Answer · 2015-01-12 07:10:09Z

1

Try

for (String key : table.values()) {
     System.out.println("Keyvalues " + key.toString());
     String value = key.toString();
     myStringArray =ArrayUtils.addAll(myStringArray, value);
}

Or

int cnt=0;

for (String key : table.values()) {
         System.out.println("Keyvalues " + key.toString());
         String value = key.toString();
         myStringArray[cnt++] =value;
    }

edited Jan 12, 2015 at 7:10

answered Jan 12, 2015 at 6:50

atish shimpi

5,0212 gold badges35 silver badges51 bronze badges

Comments

Puneet_Techie · Accepted Answer · 2015-01-12 06:51:40Z

1

ArrayUtil.add method copies the array and then adds the new element at the end of the new copied array.

So, i think that's where the problem lies in your code.

That is why myStringArray is showing the size as 0.As the myStringArray is copied and a new string array is formed and then the element is added to it.

answered Jan 12, 2015 at 6:51

Puneet_Techie

1971 silver badge6 bronze badges

Comments

Puneet_Techie · Accepted Answer · 2015-01-12 06:55:38Z

0

You can try this -:

int index =0;

for (String key : table.values()) {
            System.out.println("Keyvalues " + key.toString());
            String value = key.toString();
            myStringArray[index++] = value;            
        }

answered Jan 12, 2015 at 6:55

Puneet_Techie

1971 silver badge6 bronze badges

Comments

Vihar · Accepted Answer · 2015-01-12 06:58:47Z

0

ArrayUtils.add(myStringArray, value);

This method creates and returns a new array with the value added to it.

You need to assign the result:

myStringArray = ArrayUtils.add(myStringArray, value);

It has to be done that way because arrays cannot be resized.

edited Jan 12, 2015 at 6:58

Vihar

3,8392 gold badges26 silver badges50 bronze badges

answered Jan 12, 2015 at 6:47

Thilo

264k107 gold badges527 silver badges674 bronze badges

1 Comment

ChanGan Over a year ago

The method add(String[], String) is undefined for the type DataProviderConvertor

Ankur Singhal · Accepted Answer · 2015-01-12 07:06:23Z

0

Just two changes required, code is perfectly fine otherwise.

1.) String[] myStringArray = new String[table.size()];, change to

String[] myStringArray = null;

2.) ArrayUtils.add(myStringArray, value); change to

myStringArray = ArrayUtils.add(myStringArray, value);

Rest you can read and debug about this method in API.

answered Jan 12, 2015 at 7:06

Ankur Singhal

26.1k17 gold badges92 silver badges129 bronze badges

Collectives™ on Stack Overflow

Array is Returning NULL

6 Answers 6

Comments

Comments

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related