Comparing arrays

Question

I have String Array of a good couple hundred lines of code. I have two other String Arrays, one with values I want to replace, and the other with the value I want it to replace to. I need to go through each line of the original code and check each line if it contains anything that I need to replace, and if it does, replace it. I want to replace it to a totally different String Array, so that the original is still left unchanged. This is what I have, but it's not exactly working.

for(int i=0; i<originalCode.length; i++) {

    if( originalCode[i].contains("| "+listOfThingsToReplace[i]) ) {

        newCode[i]=originalCode[i].replaceAll(("| "+listOfThingsToReplace[i]), ("| "+listOfReplacingThings[i]));

    }

}

Obviously I need more counting variables somewhere (especially because originalCode.length !=listOfThingsToReplace.length), but I can't figure out where. Would I need more for loops? I tired doing that... but "Exception in thread "main" java.lang.OutOfMemoryError: Java heap space"... Any help please?

Use replace() which replaces all occurrences of plain-text, not replaceAll() which replaces all occurrences of a regex match. — Bohemian
– Bohemian ♦, Commented Jan 15, 2015 at 6:11

Michael Dowd · Accepted Answer · 2015-01-15 04:38:25Z

1

I think this should do the trick if I'm understanding the problem correctly

// New Code Array
String[] newCode = new String[originalCode.length];

for (int i=0; i<originalCode.length; i++) {
	// New Code Line
	String newCodeLine = originalCode[i];

	// Iterate through all words that need to be replaced
	for (int j=0; j<listOfThingsToReplace.length; j++) {
		
		// String to replace
		String strToReplace = listOfThingsToReplace[j];
		
		// String to replace with
		String strToReplaceWith = (j >= listOfReplacingThings.length) ? "" : listOfReplacingStrings[j];
		
		// If there is a string to replace with
		if (strToReplaceWith != "") {
			
			// then replace all instances of that string
			newCodeLine = newCodeLine.replaceAll(strToReplace, strToReplaceWith);
		}		
	}
	
	// Assign the new code line to our new code array
	newCode[i] = newCodeLine;
}

answered Jan 15, 2015 at 4:38

Michael Dowd

2311 silver badge5 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Jared Rummler Over a year ago

Use !strToReplaceWith.equals("") instead of !=. Plus that part doesn't even make sense; how could j be greater than the length when you have the check in your for loop.

Michael Dowd Over a year ago

You're right about the .equals, I always forget about that. I put the check with j to handle the situation where listofReplacingThings.length is less than listOfThingsToReplace.length, but may or may not be necessary

Collectives™ on Stack Overflow

Comparing arrays

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related