Overloading operator not working in C++

Question

Why is it that below code is always returning the last player in the array?

The operator bool operator > (Player &P) { return Age > P.Age; }seems not to be working properly. I see it as "compare the age of the element in the left object to the age of the element in the right object". Any suggestions?

Note: I don't intend to use std::vector or std::string.

#include <iostream>
using namespace std;

class Player {
    int Age;
    char *Name;
public:
    Player() {}
    void setName(char *n) { Name = n; }
    void setAge(int a) { Age = a; }
    bool operator > (Player &P) { return Age > P.Age; }
    void showName(){ cout << Name; }
};

int main()
{
    Player *ArrayPlayers = new Player[2];
    ArrayPlayers[0].setName("Player1");
    ArrayPlayers[0].setAge(27);
    ArrayPlayers[1].setName("Player2");
    ArrayPlayers[1].setAge(29);
    ArrayPlayers[2].setName("Player3");
    ArrayPlayers[2].setAge(24);

    Player *Oldest = &ArrayPlayers[0];
    for (int i = 0; i < 3; i++) {
        Player *Current = &ArrayPlayers[i];
        if (Current > Oldest) {
            Oldest = Current;
        }
    }

    cout << "Oldest player is: ";
    Oldest->showName();
    getchar();
}

If this is supposed to be C++, you should really drop char pointers and use a string class like std::string. It will resolve 50% of your debugging troubles. — nvoigt
– nvoigt, Commented Jan 25, 2015 at 11:54
You access out of bounds of ArrayPlayers. It has two entries, [0] and [1], however you write to [2] . — M.M
– M.M, Commented Jan 25, 2015 at 14:04

BartoszKP · Accepted Answer · 2015-01-25 11:53:41Z

3

It's because you are comparing pointers (Player*) not Player instances. The simplest fix to achieve the desired result is to dereference:

if (*Current > *Oldest) {

This will invoke your operator> implementation for the Player class.

edited Jan 25, 2015 at 11:53

answered Jan 25, 2015 at 11:46

BartoszKP

36k15 gold badges109 silver badges135 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Overloading operator not working in C++

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related