Reading data from a file and inserting into a table using Hibernate

Question

I am trying to insert data into book table by reading data from a txt file, problem is only 1 insert query is generated at the commit() statement

import java.io.BufferedReader;
import java.io.File;
import java.io.FileReader;
import java.io.IOException;
import org.hibernate.Session;
import org.hibernate.SessionFactory;
import org.hibernate.Transaction;
import org.hibernate.cfg.Configuration;

public class BookClientFile {

public static void main(String[] args) {

    SessionFactory sf = new Configuration().configure().buildSessionFactory();
    Session s1 = sf.openSession();

    BufferedReader br = null;
    Transaction trans = null;

    try {
           br = new BufferedReader(new FileReader(new File("Books.txt")));
           String line = null;
           String [] row = null;
           Book bk = null;

           trans = s1.beginTransaction();
           while((line = br.readLine()) != null) {

               bk = new Book();
               row = line.split(",");

               bk.setBookId(Integer.parseInt(row[0].trim()));
               bk.setTitle(row[1].trim());
               bk.setAuthor(row[2].trim());

               s1.save(bk);
               trans.commit();
           }

    } catch(IOException e) {
        e.printStackTrace();
    }
    finally {

        s1.flush();
        s1.close();

    try {

        if(br != null) {

            br.close();
            br = null;
        }

    } catch(IOException e) {
        e.printStackTrace();
    }
    }
}
}

Don't you need to commit outside the while loop?

sp00m
– sp00m

2015-01-28 09:01:35 +00:00
Commented Jan 28, 2015 at 9:01 — sp00m
– sp00m, Commented Jan 28, 2015 at 9:01

StanislavL · Accepted Answer · 2015-01-28 09:01:36Z

1

Swap the to lines to start transaction for each book.

       trans = s1.beginTransaction();
       while((line = br.readLine()) != null) {

Or move trans.commit(); out of the while

answered Jan 28, 2015 at 9:01

StanislavL

57.5k9 gold badges75 silver badges100 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Aamir Over a year ago

same output, the programs halts after generating one sql query.

Pramod Karandikar · Accepted Answer · 2015-01-28 09:02:48Z

0

Take trans.commit(); out of the while loop.

answered Jan 28, 2015 at 9:02

Pramod Karandikar

5,3377 gold badges45 silver badges75 bronze badges

1 Comment

Aamir Over a year ago

nothing is happening , same output Hibernate: insert into Book (book_title, book_author, book_id) values (?, ?, ?)

Collectives™ on Stack Overflow

Reading data from a file and inserting into a table using Hibernate

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related