How do you delete an empty array of objects?

Question

I am trying to create a constructor that deletes a directory objects name, then the subdirectories within the directory, and finally the directory itself. The delete [] *subDirectories line however causes segfaults whenever used.

Subdirectories are allocated by

subDirectories[subDirectoryCount++] = new Directory(arguments[1], umask, time, this); 

Directory::~Directory()
{
    delete [] name;

    for (int i = 0; i < subDirectoryCount; i++)
       delete subDirectories[i];
    delete [] *subDirectories;
}

delete [] subDirectories. Make sure subDirectories was created with new[], otherwise you have undefined behavior. — David G
– David G, Commented Feb 4, 2015 at 18:46
If it's C++ should definitively avoid C style array and use std containers like std::vector — NetVipeC
– NetVipeC, Commented Feb 4, 2015 at 18:52

Sarfaraz Nawaz · Accepted Answer · 2015-02-04 19:47:29Z

6

Write:

delete [] subDirectories;

Make sure subDirectories is allocated using new [].

Anyway, stop doing that either. Use std::vector<std::unique_ptr<Directory>> instead, Or std::vector<std::shared_ptr<Directory>> if the elements are to be shared. Either way let the library manage memory for you.

edited Feb 4, 2015 at 19:47

answered Feb 4, 2015 at 18:51

Sarfaraz Nawaz

364k121 gold badges682 silver badges867 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How do you delete an empty array of objects?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related