PHP +mysql.Dynamic website, links

Question

I'm trying to do links like: test.com/article.php?=$id where $id is from data base

  $sql = "SELECT * FROM articles WHERE writer='$w_name' ";
   $result = mysqli_query($conn, $sql);

   $q = array();
   $l = array();

   if (mysqli_num_rows($result) > 0) {

       while ($row = mysqli_fetch_assoc($result)) {
           $q[]=$row['header'];
           $l[]=$row['id'];
       }
   }

So i have for example: $q=1,2,3 and $l=1st link name,2nd link name, 3d link name.

I tried to do that together this way, but it doesn't work correct:

<? 
    foreach($q as $header)
        { 
            echo'<li>'.$header.'</li>';
        } 
?>


<?
    foreach($l as $id) 
        { 
            echo "<a href='article.php?=$id'>".$header.'<br>'.'</a>'; 
         }
?>

In this case i had 3 different links with the same name like:

<a href='article.php?=1'>1st link name</a>
<a href='article.php?=2'>1st link name</a>
<a href='article.php?=3'>1st link name</a>

Also i have tried :

 <? 
foreach($l as $id)
foreach($q as $header) 
{ echo "<a href='article.php?=$id'>".$header.'<br>'.'</a>'; } ?>



But it gave me all combinations like:

<a href='article.php?=1'>1st link name</a>
<a href='article.php?=1'>2nd link name</a>
<a href='article.php?=1'>3d link name</a>

<a href='article.php?=2'>1st link name</a>
<a href='article.php?=2'>2nd link name</a>
<a href='article.php?=2'>3d link name</a>

<a href='article.php?=3'>1st link name</a>
<a href='article.php?=3'>2nd link name</a>
<a href='article.php?=3'>3d link name</a>

I'm new to php and mysql, and i don't know how to solve this problem

Q: Why would you want to have it return ?=xxx? Get methods require something like ?var=xxx - I'm wondering how you're going to be accessing those links. I.e.: if(isset($_GET['xxx']) && ($_GET['xxx'] == "1")){...} — Funk Forty Niner
– Funk Forty Niner, Commented Feb 5, 2015 at 20:45

Mario A · Accepted Answer · 2015-02-05 20:47:59Z

2

A foreach loop is best at iterating through a single array. If you insist on having the data in 2 arrays it is easier to iterate the arrays using a for loop with an index instead of a foreach loop.

So try this:

for($i=0; $i < count($l); $i++) {
  echo "<a href='article.php?=".$l[$i]."'>".$q[$i].'<br>'.'</a>';
}

In this example the data is accessed using the index $i with $l[$i] and $q[$i].

edited Feb 5, 2015 at 20:47

answered Feb 5, 2015 at 20:32

Mario A

3,3711 gold badge20 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Marc B Over a year ago

or just build ONE array, since the headers and ids seem to be tied together at the hip...

Mario A Over a year ago

you may be right, I just thought that the opt has his reasons to split the data in 2 arrays

Misa Over a year ago

It gives me all combinations again. 9 links instead 3

Mario A Over a year ago

@Misa, please take care that there is only one for loop

showdev Over a year ago

I'd like to see more explanation of your solution. A code dump is less helpful to future coders.

Saruva · Accepted Answer · 2015-02-05 20:36:39Z

1

You just need 1 array:

$sql = "SELECT * FROM articles WHERE writer='$w_name' ";
   $result = mysqli_query($conn, $sql);

   $q = array();

   if (mysqli_num_rows($result) > 0) {

       while ($row = mysqli_fetch_assoc($result)) {
           $q[$row['id']]=$row['header'];
       }
   }

After that just print the array in the format you want:

foreach($q as $href => $text) {
    echo '<a href="http://test.com/article.php?=' . $href . '">' . $text . '</a><br />';
}

answered Feb 5, 2015 at 20:36

Saruva

4371 gold badge5 silver badges18 bronze badges

Comments

Ata ul Mustafa · Accepted Answer · 2015-02-05 20:46:00Z

0

Solution:

This soltion will consume less memory and efficient.

You can use it like this. Let say you have id and header fields in articles table. By using single iteration(loop) you can achieve your desired result.

$sql = "SELECT id,header FROM articles WHERE writer='$w_name' ";
$result = mysqli_query($conn, $sql);
if (mysqli_num_rows($result) > 0) {
   while ($row = mysqli_fetch_assoc($result)) {
       $id = $row['id'];
       echo "<a href='article.php?=$id'>" . $row['header'] . '</a>';
       echo '<br />';
   }
}

answered Feb 5, 2015 at 20:46

Ata ul Mustafa

1,20213 silver badges18 bronze badges

Collectives™ on Stack Overflow

PHP +mysql.Dynamic website, links

3 Answers 3

5 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related