Changing multiple elements in a 2D array

Question

Hi so im a beginner at Java and not all that good at it. But I have to create a battleship program. the directions say that the user has to enter the top-left coordinate and orientation (horizontal and vertical) of 3 different battle ships of lengths 2, 3 and 4. So when the user inputs what row and column they want the position of the ship to be in, i have to replace the element in the 7 x 7 array ( which is "-") and instead put "s" for ship. But it has to be changed in the location where the user wants it and the extra space depending on the length of that ship

so far i have this but it doesn't work.

System.out.println("What row would you like to place the 2 length ship?");
    int row = scan.nextInt();
    System.out.println("What column would you like to place the 2 length ship?");
    int col = scan.nextInt();
    System.out.println("Horizontally or vertically?");
    String hv = scan.next();

char [] [] brdState = new char [7][7];
     for (int r = 0; r < brdState.length; r++)
     {
         for ( int c = 0; c < brdState[r].length; c++)
         {
             brdState [r][c] = '-';
             System.out.print(brdState[r][c] + "\t");
         }
        System.out.println();

if ( hv == "h" || hv == "H");
    {
        int rl = (row - 1);
        for (int c = col; c < col; c++)
        {
            for ( int r = rl; r <= row; r++)
            {
                brdState[row][col] = 's';
                System.out.print(brdState[r][col] + "\t");
                brdState[r][c] = '-';
                System.out.println(brdState[r][c] + "\t");

            }

        }
    }

I need the code to process right where the user wants the length 2 ship to be and then one element to the left of it (horizontal) or right above it (vertical). But i can't program it correctly.

SMA · Accepted Answer · 2015-02-15 07:47:22Z

1

You would need to change this line:

if ( hv == "h" || hv == "H");

To

if ( hv.equalsIgnoreCase("H"))
             ^^^              ^

This means, you don't need semicolon at the end of if, which makes it as a null statement i.e. irrespective of whether condition is met or not, block of codes between {} will be executed always. Also while comparing two Strings, you need to make use of equals method.

answered Feb 15, 2015 at 7:47

SMA

37.2k8 gold badges53 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Changing multiple elements in a 2D array

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related