Random statement asking same statement?? Python

Question

I have been trying to make a mathimatical quiz that asks a random question then asks another random question for a range of 10 times, what my problem is is that it will ask a random question then the same question again and again and again etc.

import random

opList = ["+", "*", "-"]
numberofQuestions = 10
num1 = random.randint(0, 10)
num2 = random.randint(0, 10)
ops = random.choice(opList)
question = "%d %s %d" % (num1, ops, num2)
answer = eval(question)
totalScore = 0


childName = input("Enter your name: ")
print("Thank you for signing up for Arithmetic Quiz " + childName)
for i in range(numberofQuestions):
    reply = int(input("What is " + question + " ? "))
    if reply == answer:
        print("Correct!!")
        totalScore += 1
    else:
        print("Incorrect!!")

jam · Accepted Answer · 2015-02-25 15:18:19Z

1

Putting these lines:

num1 = random.randint(0, 10)
num2 = random.randint(0, 10)
ops = random.choice(opList)
question = "%d %s %d" % (num1, ops, num2)
answer = eval(question)

where you have means they only evaluate once, assigning randomly-selected but static values to each variable.

You need to move these statements inside your for loop, so that they get re-evaluated every time you want new values

edited Feb 25, 2015 at 15:18

answered Feb 25, 2015 at 15:03

jam

3,6885 gold badges36 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

sberry Over a year ago

Small note: the question and answer will also need to be included in the loop iteration, or they will never change either.

sberry · Accepted Answer · 2015-02-25 15:04:49Z

1

The problem is you are only generating the question (and components of the question) once. My suggestion would be to generate a new function like so:

...

def question_answer():
    num1 = random.randint(0, 10)
    num2 = random.randint(0, 10)
    ops = random.choice(opList)
    question = "%d %s %d" % (num1, ops, num2)
    answer = eval(question)
    return question, answer

for i in range(numberofQuestions):
    question, answer = question_answer()
    ...

answered Feb 25, 2015 at 15:04

sberry

133k20 gold badges145 silver badges171 bronze badges

Comments

Nadine · Accepted Answer · 2015-02-25 15:05:34Z

1

You aren't updating the num1, num2, ops, question and answer variables. You need to move them into the for loop. Otherwise they will always be equal to the first value they were assigned.

answered Feb 25, 2015 at 15:05

Nadine

1,6382 gold badges15 silver badges27 bronze badges

Collectives™ on Stack Overflow

Random statement asking same statement?? Python

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related