if array element conditional inside for loop

Question

I have a series of locations returning in an array in JavaScript that I'm plotting on a Google Map.

I'm trying to change the type of marker icon depending the value on one of the array elements like so

for (i = 0; i < locations.length; i++) {
  marker = new google.maps.Marker({
    position: new google.maps.LatLng(locations[i][1], locations[i][2]),
    map: map,
    if (locations[i][3] == "Yes") {
      console.log("yes")
    } else {
      console.log("no")
    }
  });

  google.maps.event.addListener(marker, 'click', (function(marker, i) {
    return function() {
      infowindow.setContent(locations[i][0]);
      infowindow.open(map, marker);
    }
  })(marker, i));
}

but running into

Uncaught SyntaxError: Unexpected token (

What am I missing?

yeah, that does work but I should have been more specific: within the new google.maps.Marker({ I need to be able to set icon: '/img/a.png' or icon: '/img/b.png' depending on the value of locations[i][3] — Steven Grant
– Steven Grant, Commented Feb 26, 2015 at 12:23
you can use self executing function like so jsbin.com/tacoro/2/edit?js,output, or use ternary operator jsbin.com/tacoro/3/edit?js,output — Oleksandr T.
– Oleksandr T., Commented Feb 26, 2015 at 12:25

T.J. Crowder · Accepted Answer · 2015-02-26 12:29:25Z

2

What am I missing?

You're putting flow code in the middle of an object initializer:

for (i = 0; i < locations.length; i++) {
  marker = new google.maps.Marker({
    position: new google.maps.LatLng(locations[i][1], locations[i][2]),
    map: map,
    if (locations[i][3] == "Yes") {     // ====
      console.log("yes")                // ====
    } else {                            // ==== Here
      console.log("no")                 // ====
    }                                   // ====
  });

  google.maps.event.addListener(marker, 'click', (function(marker, i) {
    return function() {
      infowindow.setContent(locations[i][0]);
      infowindow.open(map, marker);
    }
  })(marker, i));
}

You can't do that. ~~I'm not sure what you're trying to do there~~ You've posted a clarifying comment:

within the new google.maps.Marker({ I need to be able to set icon: '/img/a.png' or icon: '/img/b.png' depending on the value of locations[i][3]

So my guess about a property was correct: You can do that with the conditional operator:

marker = new google.maps.Marker({
  position: new google.maps.LatLng(locations[i][1], locations[i][2]),
  map: map,
  icon: locations[i][3] == "Yes" ? '/img/a.png' : '/img/b.png'
});

...where the icon property's value will be '/img/a.png' if locations[i][3] == "Yes" is true, or '/img/b.png' if not.

edited Feb 26, 2015 at 12:29

answered Feb 26, 2015 at 12:24

T.J. Crowder

1.1m201 gold badges2k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Steven Grant Over a year ago

I'm going to accept this on the basis of it being more succinct

Collectives™ on Stack Overflow

if array element conditional inside for loop

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related