Onclick element of Submit Button Not Calling JS Function

Question

Hi I'm familiar with using onsubmit and onclick as I have used them before, but for some reason it refuses to work this time around. I've looked at my old code and tried everything to make it exactly the same yet it still will not run.

function verifypass()
{
var password = "Testpass";
var string = document.getElementByID("verifybadge");
if(string!=password) {
alert("Wrong password!");
window.location="about:blank";
}
}

<form name="receivingform" method="post">
</br></br>
<b>Please Enter Password to Verify Closure of Ticket: </b> </br>
<input type="text" size="15" maxlength="20" id="verifybadge"> </br>
<input class="button_text" type="submit" value="Delete Closed Rows"      onclick="verifypass();">
</form>

Tommaso Bertoni · Accepted Answer · 2015-03-02 16:16:57Z

3

Man, it's document.getElementById
by the way, let's clean that code:

HTML:

<form name="receivingform" method="post">
    <br/><br/>
    <b>Please Enter Password to Verify Closure of Ticket: </b> <br/>
    <input type="text" size="15" maxlength="20" id="verifybadge" /> <br/>
    <input class="button_text" type="submit" value="Delete Closed Rows" onclick="verifypass()" />
</form>

Javascript:

function verifypass() {
    var password = "Testpass";
    var string = document.getElementById("verifybadge").value;
    if(string !== password) {
        alert("Wrong password!");
        window.location="about:blank";
    }
}

This code works (notice the .value as suggested by @John)

Under here a snippet:

function verifypass() {
  var password = "Testpass";
  var string = document.getElementById("verifybadge").value;
  if(string !== password) {
    alert("Wrong password!");
    //window.location="about:blank";
  } else alert("yay");
}

<form name="receivingform" method="post">
  <br/><br/>
  <b>Please Enter Password to Verify Closure of Ticket: </b> <br/>
  <input type="text" size="15" maxlength="20" id="verifybadge" /> <br/>
  <input class="button_text" type="button" value="Delete Closed Rows" onclick="verifypass()" />
</form>

edited Mar 2, 2015 at 16:16

answered Mar 2, 2015 at 15:37

Tommaso Bertoni

2,3811 gold badge24 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

AggieIE Over a year ago

Guess its going to be one of those days. Happy Monday everyone

Mouser Over a year ago

@AggieEngr, You could've simply debugged this in the console.

AggieIE Over a year ago

As it was displayed, I am pretty new to this @Mouser. Thanks for the heads up though, I'll use the console from now on

AggieIE Over a year ago

Hey now even if I submit the right password, the alert is still popping up saying its the wrong password. Any ideas?

Tommaso Bertoni Over a year ago

try modifying != to !== so it results: if(string !== password)

|

Collectives™ on Stack Overflow

Onclick element of Submit Button Not Calling JS Function

1 Answer 1

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related