Simple Javascript timed counter

Question

I am doing the following:

function countUp(c){
  c.value = c.value + 1;
  $('#number').text(c.value);
}

var counter = {value: 0};

window.setTimeout(countUp(counter), 100);

For some reason the value of my counter seems to always stay 1. I tried using an object instead of a variable because it was my understanding that objects are passed by reference, not value, and I hoped I could change this value through my countUp function.

It's clearly not working, what's wrong?

Here is a Codepen

Is there a reason you are making counter a class with a value property, instead of just as a normal var: ie - var counter = 0; — David P
– David P, Commented Mar 3, 2015 at 15:11
I might be wrong, but if I simply a variable it seems to not be working. With an object, I can change the object value within my countUp function. I am learning (forever noob) so I might be wrong... Check it in the codepen link — akmur
– akmur, Commented Mar 3, 2015 at 15:48

Mike · Accepted Answer · 2015-03-03 15:09:26Z

5

You want setInterval. setTimeout is a one-shot deal.

setInterval(function () {
  countUp(counter)
}, 100);

answered Mar 3, 2015 at 15:09

Mike

4,09125 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Mike Over a year ago

Put your function call into an actual function as well. Edited my post.

akmur Over a year ago

Super, thanks!, I'll choose your answer in 10 minutes :)

Collectives™ on Stack Overflow

Simple Javascript timed counter

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related