Implementing Common Redirect Code in MVC

Question

I'm trying to work out how to re-use some code in my MVC controller actions. I want to redirect to another page if a status of something is set. I've written a method to do this but it seems as if I'd have to paste this across every controller action e.g.

[HttpGet]        
public virtual ActionResult DoThis(Guid id)

    ActionResult result;
    if (checkRedirect(out result))
    {
            return result;
    }

   //otherwise continue

I thought I might be able to do this using an Action Filter but then I have to set up property injection in the filter in order to check my status which I want to avoid. There must be a common way of doing this that I'm missing...?

Action filters are the right approach. If you can guarantee that the property will always have a constant name, then you can simply look for that single property in the filter and check if it exists. If the name will vary per action, then have the attribute take in the property name as a parameter. — Justin Helgerson
– Justin Helgerson, Commented Mar 19, 2015 at 17:09

Ehsan Sajjad · Accepted Answer · 2015-03-20 10:06:45Z

2

Way 1:

Make a base controller and inherit other controllers from it:

public class DefaultController : Controller
{
   protected override void OnActionExecuting(ActionExecutingContext filterContext)
   {
       ActionResult result;
       if (checkRedirect(out result))        
       {
           filterContext.Result = result; // redirect
       }

    }
}

and in your controller:

public class SomeController : DefaultController
{
  [HttpGet]        
  public virtual ActionResult DoThis(Gud)
  {
     // do something here which you were putting in else part
  }
}

Way 2:

or create action filter attribute:

public class MyCustomAttribute : ActionFilterAttribute
{
    public override void OnActionExecuting(ActionExecutingContext filterContext)
    {

       ActionResult result;
       if (checkRedirect(out result))        
       {
           filterContext.Result = result; // redirect
       }

    }

}

and put it on your action:

 public class SomeController : Controller
 {
  [HttpGet]
  [MyCustom]        
  public virtual ActionResult DoThis(Gud)
  {
      // do something here which you were putting in else part
  }
}

edited Mar 20, 2015 at 10:06

answered Mar 19, 2015 at 17:12

Ehsan Sajjad

62.6k16 gold badges113 silver badges171 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Mark Dixon Tech Over a year ago

I would like to do Way 2 but doing the DI on the Filter seems a bit of a fiddle. I think I'll use Way 1 for now, thanks

Collectives™ on Stack Overflow

Implementing Common Redirect Code in MVC

1 Answer 1

Way 1:

Way 2:

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Way 1:

Way 2:

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related