For loop containing if statements does not loop again

Question

Below is a method that takes in studentarray and the topStudentIndexof a value calculated by another method previous.

I have multiple objects in my array. However, the for loop only managed to loop through once, and it returned the first value straight away.

I have no clue why the for loop stopped even though my st.lengthis more than

public static int computeNextHighestOverallStudentIndex(Student[] st, int topStudentIndex) {

    double nextHighestOverall= 0;
    int nextHighestStudentIndex = 0;
    for (int i = 0; i < st.length; i++) {
            if ((st[i] != null) && (!(i == topStudentIndex))){
                double studentOverall = st[nextHighestStudentIndex ].getOverall();
                if (studentOverall > nextHighestOverall) {
                    nextHighestOverall= studentOverall;
                    nextHighestStudentIndex = i;
                }
            }
        }
    return nextHighestStudentIndex ;
}

Eran · Accepted Answer · 2015-03-29 07:54:17Z

1

It looks like

double studentOverall = st[nextHighestStudentIndex ].getOverall();

should be

double studentOverall = st[i].getOverall();

since you want to check all the Students in the array and not just the first one (st[nextHighestStudentIndex ] will always return the first Student, since you initialize nextHighestStudentIndex to 0).

answered Mar 29, 2015 at 7:54

Eran

395k57 gold badges726 silver badges793 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

gymcode Over a year ago

thank you @Eran, after changing it worked. I will accept your answer in a moment, for the timer to expire

smaug · Accepted Answer · 2015-03-29 08:08:23Z

1

You want to traverse the entire array using st[i] (not st[nextHighestStudentIndex])

answered Mar 29, 2015 at 8:08

smaug

93611 silver badges28 bronze badges

Collectives™ on Stack Overflow

For loop containing if statements does not loop again

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related