Cannot read property 'get' of undefined with Angular

Question

I am trying to build a simple authentication using angular, it gives this error when making a ajax service call. Here is the code.

Code

mainModule.controller("loginController", ['$scope', '$http', '$rootScope', '$presence', '$apps', '$helpers',
    function($scope, $http, $rootScope, $presence, $apps, $helpers) {
        $scope.currentUser;
        $scope.password;
        $rootScope.url = "http://localhost:53455/eSuperVision.svc";
        $scope.login = function($scope, $http) {
            $http.get($rootScope.url + "/login/" + $scope.currentUser + "/" + $scope.password).success(function(response) {
                if (response == true) {
                    location.href = "home.html";
                } else {
                    $("#loginDialog").effect("shake");
                    $scope.showError = true;
                }
            });
        }
    }
]);

cuttlas · Accepted Answer · 2015-04-03 11:57:28Z

2

Because the $http you are using in your login fuction is not the $http service injected in the controller but an arbitrary param passed to the function.

Just remove it: $scope.login = function() {...}

answered Apr 3, 2015 at 11:57

cuttlas

9816 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Pankaj Parkar Over a year ago

you beat me by 28 seconds :p

Pankaj Parkar · Accepted Answer · 2015-04-03 11:57:57Z

1

You function should not pass arguments of $http & $scope, they are getting overridden by a function and both of them got undefined. you should use the dependency which you have injected from controller.

Code

$scope.login = function() {
  $http.get($rootScope.url + "/login/" + $scope.currentUser + "/" + $scope.password).success(function(response) {
    if (response == true) {
      location.href = "home.html";
    } else {
      $("#loginDialog").effect("shake");
      $scope.showError = true;
    }
  });
}

answered Apr 3, 2015 at 11:57

Pankaj Parkar

136k23 gold badges241 silver badges307 bronze badges

Collectives™ on Stack Overflow

Cannot read property 'get' of undefined with Angular

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related