Error when returning in method

Question

In my selectUser class I have:

 public checkEmail(string email)
    {
           peopleTableAdapters.PeoplesTableAdapter p = new peopleTableAdapters.PeoplesTableAdapter();
           return p.checkEmail(email);

    }

In the client side code I have:

protected void Button1_Click(object sender, EventArgs e)
{

 selectUser s = new selectUser();
 try
   {
      s.checkEmail(email.Text);       
   }
 catch(Exception e)
   {

   }
}

I am getting this error with the "return p.checkEmail(email);" the error is:

"Error 307 Since 'authentication.checkEmail(string)' returns void, a return keyword must not be followed by an object expression"

Does anyone understand what I am doing wrong?

I dont want to return any data because its not needed I just want to return something so it succeeds in the try statement.

This code should fail with Method (.....) must have a return type — Steve
– Steve, Commented Apr 5, 2015 at 22:21
You should review C# Coding Conventions (msdn.microsoft.com/en-us/library/ff926074.aspx) as you naming of functions and classes is very counter-intuitive. — Kaspars Ozols
– Kaspars Ozols, Commented Apr 5, 2015 at 22:22
@KasparsOzols The selectUser is a class. They're both different parts of code in different classes — Samrikan
– Samrikan, Commented Apr 5, 2015 at 22:33
Exactly. And class names should be in Pascal case. Instance names should be in Camel case. Like in SelectUser selectUser = new SelectUser(). If you stick to that rule, you will soon find that it is much more easier to read such code. — Kaspars Ozols
– Kaspars Ozols, Commented Apr 5, 2015 at 22:35

mason · Accepted Answer · 2015-04-05 22:25:45Z

1

This has no return type:

public checkEmail(string email)

I'm surprised this even compiles, but maybe the compiler assumes void when nothing is specified? I didn't know it did that. But either way, there's no return type. So this won't work:

return p.checkEmail(email);

If the method doesn't have a return type, then it can't return anything. You also don't do anything with the returned value:

s.checkEmail(email.Text);

So you don't need to return anything at all.

Furthermore, the error also suggests that p.checkEmail(email) itself doesn't return anything. So trying to return something which itself is a void return type is just compounding the problem.

Since nothing in this code returns any value, you can probably resolve this by simply not trying to return anything at all:

public void checkEmail(string email)
{
    peopleTableAdapters.PeoplesTableAdapter p = new peopleTableAdapters.PeoplesTableAdapter();
    p.checkEmail(email);
}

edited Apr 5, 2015 at 22:25

mason

32.8k12 gold badges83 silver badges127 bronze badges

answered Apr 5, 2015 at 22:15

David

221k42 gold badges246 silver badges338 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Samrikan Over a year ago

But it now says "Method must have a return type"

David Over a year ago

@Samrikan: And it didn't say that before? At all? I still highly suspect that public checkEmail(string email) isn't valid syntax. I'd never heard of C# automatically inferring a void return type. You may have to specify it manually. It's likely that this error was also happening in your original code and you simply weren't paying attention to the error.

Kaspars Ozols Over a year ago

just add void between public and checkMail in function definition

Travis · Accepted Answer · 2015-04-05 22:17:47Z

0

To exp[and on David's answer, if you don't want either checkEmail method to return a value, then you will need to throw an exception for an invalid e-mail at whatever point in the chain you are determining that it is or isn't valid.

This can be done using throw new ArgumentException() replacing ArgumentException with whatever exception type you feel is appropriate.

answered Apr 5, 2015 at 22:17

Travis

6995 silver badges11 bronze badges

Collectives™ on Stack Overflow

Error when returning in method

2 Answers 2

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related