Why is it keep on asking when I input correctly?

Question

def main():

 month = 0
 date = 0
 year = 0
 date = [month, date, year]
 user = input("Enter according to mm/dd/yy:")
 user = user.split('/')
 month = user[0]
 date = user[1]
 year = user[2]
 while int(month) > 12  or int(month) < 1 :
    print("Month is incorrect.")
    user = input("Enter according to mm/dd/yy:")
 while int(date) > 31 or int(date) < 0:
    print("Date is incorrect.")
    user = input("Enter according to mm/dd/yy:")
 while int(year) > 15 or int(year) < 15:
    print("Year is incorrect.")
    user = input("Enter according to mm/dd/yy:")

I keep on getting Month incorrect when it's correct. Please help. I'm trying to get the user's input to match the correct form of mm/dd/yy. And I'm trying to convert yy -> 2015. Please help.

Please put a language tag on this question.

takendarkk
– takendarkk

2015-04-10 01:45:06 +00:00
Commented Apr 10, 2015 at 1:45 — takendarkk
– takendarkk, Commented Apr 10, 2015 at 1:45
You don't update month, date or year...

nneonneo
– nneonneo

2015-04-10 01:45:39 +00:00
Commented Apr 10, 2015 at 1:45 — nneonneo
– nneonneo, Commented Apr 10, 2015 at 1:45

praveen kotekal · Accepted Answer · 2015-04-10 02:31:03Z

2

There is a bug in your code. Suppose if my input is "15/30/15", then it says incorrect month and tries to fetch user input in format "mm/dd/yy", but now the user is not spliting based on '\', so the while loop keeps running till the user[0] is assigned to new month. This error occurs for incorrect date and year as well. To fix it just call the user input function and split the user inside the while loop itself.

answered Apr 10, 2015 at 2:31

praveen kotekal

211 bronze badge

Sign up to request clarification or add additional context in comments.

1 Comment

lastdancestop Over a year ago

Hi! Is it possible if you could write out the code for me to see? I'm still new at python so it's a little confusing. Thanks

Community · Accepted Answer · 2017-05-23 11:44:27Z

1

Just like @nneonneo's comment pointed out, you forgot to update month, date and year.

This would cause your while-loop to only use the very first recorded values for these fields.

Your current problem can be solved simply by adding this code at the end of each while-loop:

 user = input("Enter according to mm/dd/yy:")
 month,date,year = user.split('/')

As you might have guessed, the above is a nicer implementation of this piece of code from your question:

 user = input("Enter according to mm/dd/yy:")
 user = user.split('/')
 month = user[0]
 date = user[1]
 year = user[2]

This would reduce the clutter in every while-loop.

Also, assuming your current indentation is correct, your code won't give you your desired output because it is not accounting for the case where the user starts with all 3 invalid fields: month, date and year. If the user enters a correct month first, he would be able to enter an invalid month later on and still produce an output.

Instead of using three while loops, you should use an if-elif-else block. This would ensure you get a proper answer:

def main():

    user = input("Enter according to mm/dd/yy:")
    month,date,year = user.split('/')

    while True:

        if int(month) > 12  or int(month) < 1 :
            print("Month is incorrect.")
        elif int(date) > 31 or int(date) < 0:
            print("Date is incorrect.")
        elif int(year) > 15 or int(year) < 15:
            print("Year is incorrect.")
        else:
            break
        user = input("Enter according to mm/dd/yy:")
        month,date,year = user.split('/')

main()

edited May 23, 2017 at 11:44

CommunityBot

11 silver badge

answered Apr 10, 2015 at 2:47

logic

1,7153 gold badges16 silver badges22 bronze badges

2 Comments

lastdancestop Over a year ago

I tried this a while ago. But it gave the error of the year. ValueError: invalid literal for int() with base 10: '/'

logic Over a year ago

@lastdancestop You probably didn't split() the input correctly, that error only shows up if you try to use the int() method on an input that cannot be converted to type int. For example, you might have done int(month) when month was equal to "32/" or something

Collectives™ on Stack Overflow

Why is it keep on asking when I input correctly?

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related