FORTRAN variable output not equal to input

Question

First of all I am a complete novice to FORTRAN, and most forms of programming in general. With that said I am attempting to build a box, then randomly generate x, y, z coordinates for 100 atoms. From there, the goal is to calculate the distance between each atom and perform some math on the distance result. Below is my code. Even though n is defined as 100, and will print '100', when I print cx I only get 20 results.

    program energytot
    implicit none

    integer :: i, n, j, seed(12), k, m
    double precision:: sigma, r, epsilon, lx, ly, lz
    double precision, dimension(:), allocatable :: cx, cy, cz, dx, dy, dz, x, y, z, LJx, LJy, LJz
    allocate(x(n), y(n), z(n), LJx(n), LJy(n), LJz(n), dx(n), dy(n), dz(n))
    n = 100 !Number of molecules inside the box
    sigma = 4.1
    epsilon = 1.7
    !Box length with respect to the axis
    lx = 15
    ly = 15
    lz = 15

    do i=1,12
        seed(i)=1+3
    end do
    !generate n random numbers for x, y, z
    call RANDOM_SEED(PUT = seed)
    call random_number(x)
    call random_number(y)
    call random_number(z)
    !convert random numbers into x, y, z coordinates with (0,0,0) as the central point
    cx = ((2*x)-1)*(lx*0.5)
    cy = ((2*y)-1)*(lx*0.5)
    cz = ((2*z)-1)*(lz*0.5)

    do j=1,n-1
        do k=j+1,n
            dx = ABS((cx(j) - cx(j+1)))
            LJx = 4 * epsilon * ((sigma/dx(j))**12 - (sigma/dx(j))**6)
            dy = ABS((cy(j) - cy(j+1)))
            LJy = 4 * epsilon * ((sigma/dy(j))**12 - (sigma/dy(j))**6)
            dz = ABS((cz(j) - cz(j+1)))
            LJz = 4 * epsilon * ((sigma/dz(j))**12 - (sigma/dz(j))**6)
        end do
    end do
    print*,cx
    print*,x
    end program energytot

I've rolled back your edit, which essentially removed the question. If John Bollinger's answer was helpful, then please consider accepting and/or upvoting it instead. This way, we retain the question's use for later readers who may have similar problems. — francescalus
– francescalus, Commented Apr 13, 2015 at 22:32
@francescalus: I had thought about that as I was doing it, but I thought that John Bollinger's answer, which contained the erroneous portion of my code was enough. I apologize, please excuse my newbieousity. — Charles Butler
– Charles Butler, Commented Apr 13, 2015 at 22:38
There's no harm done, but a good rule for a question edit is: "do the answers still make sense?". Also, if you are still uncertain about getting the size of the array you really need, then it may be more appropriate to ask a new question (perhaps linking to this one). — francescalus
– francescalus, Commented Apr 13, 2015 at 22:44

John Bollinger · Accepted Answer · 2015-04-13 22:00:11Z

1

You declare cx (and cy and cz) allocatable, but you do not allocate space for them. Moreover, before you assign a value to variable n, you use it as the number of elements to allocate for your other allocatables. Why do any of those even need to be dynamically allocated in the first place?

I would replace this code ...

    integer :: i, n, j, seed(12), k, m
    double precision:: sigma, r, epsilon, lx, ly, lz
    double precision, dimension(:), allocatable :: cx, cy, cz, dx, dy, dz, x, y, z, LJx, LJy, LJz
    allocate(x(n), y(n), z(n), LJx(n), LJy(n), LJz(n), dx(n), dy(n), dz(n))
    n = 100 !Number of molecules inside the box

... with this:

    integer, parameter :: n = 100
    integer :: i, j, seed(12), k, m
    double precision :: sigma, r, epsilon, lx, ly, lz
    double precision, dimension(n) :: cx, cy, cz, dx, dy, dz, x, y, z, LJx, LJy, LJz

I also observe that in the loop where you compute distances, you loop over variable k, but you do not use its value. As a result, it looks like you compute the same distances many times over.

edited Apr 13, 2015 at 22:00

answered Apr 13, 2015 at 21:34

John Bollinger

191k11 gold badges103 silver badges207 bronze badges

Sign up to request clarification or add additional context in comments.

13 Comments

francescalus Over a year ago

As a minor quibble: I would avoid "initialize" for n which means something quite specific and inapplicable. Also, cx etc. are automatically allocated by the rules of Fortran 2003.

Charles Butler Over a year ago

I haven't found a way to incorporate it yet, but cx (cy, cz) is going to be substantially larger than n itself. There are 100 atoms so I need the distance between atom 1 and 2 and 3 and 4 and 5... to 100 and then 2 and 3 and 4...

John Bollinger Over a year ago

@francescalus, right, I was a bit sloppy there. I hope my update is more satisfactory.

francescalus Over a year ago

Thanks. I'm a bit sensitive to that issue, perhaps. But still, cx is allocated under Fortran (not ifort without explicitly asking, older compilers). [But seemingly to the wrong size (which we can't resolve), given asker's comment above.]

francescalus Over a year ago

Undefined allocation status is not applicable here (and doesn't happen after Fortran 90). Until cx is allocated in this program it is "not allocated". However, in Fortran 2003 (see 7.4.1.3) and later such allocation does occur on intrinsic assignment of the allocatable variable. Yes, under the rules of Fortran 95 (or ifort) this would be invalid code. More so than just the undefined use of n, that is.

|

Collectives™ on Stack Overflow

FORTRAN variable output not equal to input

1 Answer 1

13 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

13 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related