Use same model data in controller's actions

Question

I have a controller and two actions.

In my Products action I am filling my collection. And then when I call Index action, ProductManager.ReadProducts() method called again.

I don't want to connect to the database on second action call.

public class ProductController : Controller
{
    public List<Product> ProductsList = ProductManager.ReadProducts();

    public ActionResult Index(long Id)
    {
        return View(ProductsList.FirstOrDefault(x => x.Id == Id));
    }

    public ActionResult Products()
    {
        return PartialView(ProductsList);
    }
}

Not quite sure what the problem is. Do you say that you get two DB connections? Or two DB queries? Or you want to cache in memory the DB results? Either way, please add more code that's relevant to your question. — Cristik
– Cristik, Commented Apr 15, 2015 at 7:49
Why not? You need to get the values from somewhere. You could always cache them somewhere, e.g. use Session — user3559349
– user3559349, Commented Apr 15, 2015 at 7:50
it's ok to cache large data (100 rows of some data), or it's better to request one row data every time?? — Armen Mkrtchyan
– Armen Mkrtchyan, Commented Apr 15, 2015 at 8:02

Community · Accepted Answer · 2017-05-23 12:29:58Z

As @stephen-muecke mentioned you have few solutions

Solution 1: Session but keep in mind that Session is per user. If your products are user specific you can use it.

public class ProductController : Controller
{
    public List<Product> ProductsList {
            get { 
                var products = (Session["ProductsList"] as List<Product>);
                if(products == null)
                {
                    products = ProductManager.ReadProducts();
                    Session["ProductsList"] = products;
                }

                return products;
            }
        }

    // actions
}

Solution 2: Caching which is for all users, if your products are for all users you store in a single place for all of them.

public class ProductController : Controller
{
    public List<Product> ProductsList {
            get { 
                var products = (HttpRuntime.Cache["ProductsList"] as List<Product>);
                if(products == null)
                {
                    products = ProductManager.ReadProducts();
                    HttpRuntime.Cache["ProductsList"] = products;
                }

                return products;
            }
        }

    // actions
}

Solution 3: You can make use of OutputCache to cache the output of actions.

public class ProductController : Controller
{
    public List<Product> ProductsList = ProductManager.ReadProducts();

    [OutputCache(Duration=60, VaryByParam="*")] 
    public ActionResult Index(long Id)
    {
        return View(ProductsList.FirstOrDefault(x => x.Id == Id));
    }

    [OutputCache(Duration=60, VaryByParam="none")]
    public ActionResult Products()
    {
        return PartialView(ProductsList);
    }
}

Igor Semin · Accepted Answer · 2015-04-15 08:04:53Z

2

Use one of the shared container, for example Session

public class ProductController : Controller
{
    public ActionResult Index(long Id)
    {
        return View(GetProductList().FirstOrDefault(x => x.Id == Id));
    }

    public ActionResult Products()
    {
        return PartialView(GetProductList());
    }

    private IList<Product> GetProductList()
    {
        var productList = Session["ProductsList"];

        if (productList != null)
        {
            return productList;
        }

        productList = ProductManager.ReadProducts();
        Session["ProductsList"] = productList;

        return productList;
    }
}

edited Apr 15, 2015 at 8:04

answered Apr 15, 2015 at 8:04

Igor Semin

2,5061 gold badge22 silver badges22 bronze badges

2 Comments

Armen Mkrtchyan Over a year ago

it's ok to cache large data (100 rows of some data), or it's better to request one row data every time??

Igor Semin Over a year ago

@Armen why not? if you don't want make mass request for db you must use cache - session(if your server is allow) or redis for local cache data on server

Collectives™ on Stack Overflow

Use same model data in controller's actions

2 Answers 2

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related