Django Class view didn't return an HttpResponse object. It returned None instead

Question

urls.py

from housepost.views import ListingPost
...
url(r'^house_post/$', ListingPost.as_view(), name='post_house'),
...

views.py

from django.http import HttpResponse
from django.contrib import messages
from django.views.generic import View
from django.contrib.auth.decorators import login_required
from django.utils.decorators import method_decorator

class ListingPost(View):

    def get(self, request, *args, **kwargs):
        messages.error(request, 'asdf', extra_tags = 'error')
        return HttpResponse('Hi')

    @method_decorator(login_required)
    def dispatch(self, *args, **kwargs):
        super(ListingPost, self).dispatch(*args, **kwargs)

I'm returning an HttpResponse on a get request, yet I keep getting an error:

error message

The view housepost.views.ListingPost didn't return an HttpResponse object. It returned None instead.

Where am I going wrong?

is the user logged in,in this case.You have placed a decorator for checking that. — Zealous System
– Zealous System, Commented Apr 20, 2015 at 10:09
@user2190496 For your next questions...You saw it's bad thing omitting relevant info — JuniorCompressor
– JuniorCompressor, Commented Apr 20, 2015 at 10:11

JuniorCompressor · Accepted Answer · 2015-04-20 10:09:29Z

4

dispatch returns a HttpResponse but you don't return anything when you override it. This is the method that calls get or post and returns the response on their behalf. So the following should work:

def dispatch(self, *args, **kwargs):
    return super(ListingPost, self).dispatch(*args, **kwargs)

answered Apr 20, 2015 at 10:09

JuniorCompressor

20.1k4 gold badges33 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Daniel Roseman · Accepted Answer · 2015-04-20 10:09:13Z

1

Your dispatch method needs to actually return the result of calling the superclass method:

return super(ListingPost, self).dispatch(*args, **kwargs)

answered Apr 20, 2015 at 10:09

Daniel Roseman

602k68 gold badges911 silver badges924 bronze badges

Collectives™ on Stack Overflow

Django Class view didn't return an HttpResponse object. It returned None instead

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related