File Read Error in C

Question

This code does not read the full text file.namely,first 30-40 does not read the word. why ?

word source : http://www.cs.hmc.edu/~geoff/classes/hmc.cs070.200009/homework10/simple.dict

#include <stdio.h>
#include <stdlib.h>

int main()
{
FILE *fp = fopen("simple.txt","r");

char buf[25];

while (!feof(fp))

{
    fscanf(fp,"%s",buf);
    printf(" %s\n ", buf);

}
fclose(fp);
return 0;

}

"does not read the word"? Huh? Your code skips the first 30-40 lines of text? — Marc B
– Marc B, Commented Apr 21, 2015 at 14:34
Source file called "simple.dict", this code attempts to read "simple.txt". — chux
– chux, Commented Apr 21, 2015 at 14:36
Probably, It is beyond the upper limit of the console buffer. try like as a.out | more — BLUEPIXY
– BLUEPIXY, Commented Apr 21, 2015 at 14:48

unwind · Accepted Answer · 2015-04-21 14:35:30Z

1

There are some fishy things:

Check that the file open didn't fail before relying on it.
Don't use feof() like that, it's not what it's for and it won't work.
You only reserve room for 25 characters, that's not very long (your longest word seems to be 14 characters though, so it should be fine).
You should check the return value of fscanf() (in fact, that can be used to replace feof()).

answered Apr 21, 2015 at 14:35

unwind

402k64 gold badges492 silver badges620 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

john alanson Over a year ago

I did 14 characters reserved.This time, the first 30 words read.

unwind Over a year ago

@johnalanson Noooo, don't decrease it! 25 is pretty low as is, and you must have room for the string terminator! 14 won't work.

john alanson Over a year ago

does not unfortunately.

Sandro Kalatozishvili · Accepted Answer · 2015-04-21 14:57:59Z

0

you can open file and line-by-line read file context like that

int main() 
{
    /* Used variables */
    FILE *file;
    char *line = NULL;
    size_t len = 0;
    ssize_t read;

    /* Open file descriptor */
    file = fopen("simple.txt", "r");
    if(file != NULL)
    {

        /* Line-by-line read file */
        while ((read = getline(&line, &len, file)) != -1) 
        {
            /* Print line */
            printf("%s\n", line);
        }

        /* Close file descriptor and free line */
        fclose(file);
        if (line) free(line);
    }
    else printf("Can not open file\n");

    return 0;
}

getline() returns -1 when there is no more lines in file

answered Apr 21, 2015 at 14:57

Sandro Kalatozishvili

6025 silver badges9 bronze badges

Collectives™ on Stack Overflow

File Read Error in C

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related