How to display an integer into a div

Question

I am working on getting the user t input a number for something in this case it would be a resistor value, I have asked them via a prompt to pick a number and then if that number is within the limits I have set then the number would be displayed back to the user within a div.

I have built this already and got it to work with a couple of test messages so I believe the function itself is fine however I am having a problem that whenever the user enters a correct value that value isn't displayed but "undefined" is displayed instead.

This is the HTML I am testing,

<button onclick="R1Value()">Change Value</button>
<div id="test3"></div>

And this is the JavaScript function

function R1Value() {
var R1ValueEntered = prompt("please enter a value for R1:")
var R1 = parseInt(R1ValueEntered)
var display = document.getElementById('test3');

if (R1 >= 120 && R1 <= 1000000) {
    display.innerHTML = R1.value;
} 
else {
    alert("That is an incorrect value please enter one between 120Ohms and 1MOhm.");
    }
}

I have placed into into a jsfiddle as even though there isn't a lot of code it may save you some time if you can have a look, http://jsfiddle.net/2ufnK/72/ I may be missing something simple but I can't seem to fix the problem.

display.innerHTML = R1.value; Integers don't have a value property. — zzzzBov
– zzzzBov, Commented Apr 21, 2015 at 16:34
@zzzzBov Ah thank you so much, i'm sorry it was a silly question but i just couldn't see it, well I know for next time thanks again. Have a nice day! — Liam
– Liam, Commented Apr 21, 2015 at 16:36

A.J. Uppal · Accepted Answer · 2015-04-21 17:12:38Z

5

Just remove .value :

if (R1 >= 120 && R1 <= 1000000) {
    display.innerHTML = R1;
}

FIDDLE

edited Apr 21, 2015 at 17:12

A.J. Uppal

19.3k7 gold badges47 silver badges82 bronze badges

answered Apr 21, 2015 at 16:34

R3tep

12.9k10 gold badges53 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Liam Over a year ago

@R3tep Thank you for this I am sorry I don't have enough rep to upvote your reply, unless i am doing that wrong too! But thank you for this I am sorry it was so simple! Have a nice day!

chiapa Over a year ago

@A.J., you don't need to downvote an answer just because you beat it to seconds. The user was probably typing at the same time than you and it happened that you were faster by seconds. "Already answered" and downvote would fit better if the user had answered like 10 minutes later. The same goes for your comment on the answer of sdla4ever

R3tep Over a year ago

@Liam Validate the answer is perfect ;)

Liam Over a year ago

@R3tep Of course thank you for the help! And I just earned enough rep to upvote, enjoy! :)

user4799506 · Accepted Answer · 2015-04-21 16:41:59Z

4

.value is undefined for integers. Remove that and your code will work fine.

answered Apr 21, 2015 at 16:41

user4799506

Comments

A.J. Uppal · Accepted Answer · 2015-04-21 17:12:56Z

3

You don't need the R1.value. Just calling R1 will return it's value.

edited Apr 21, 2015 at 17:12

A.J. Uppal

19.3k7 gold badges47 silver badges82 bronze badges

answered Apr 21, 2015 at 16:34

sdla4ever

1281 silver badge15 bronze badges

3 Comments

A.J. Uppal Over a year ago

@Andy, yes but this exact information is contained in my answer, thus it is of no help to anyone.

sdla4ever Over a year ago

@A.J. I didn't hit refresh before typing my answer so your answer was not there.

Liam Over a year ago

Either way thank you all for the answers they were all appreciated, have a nice day all of you :)

Hien Luong · Accepted Answer · 2015-04-21 16:36:40Z

1

you got an error here, you assign R1 value, not R1.value

if (R1 >= 120 && R1 <= 1000000) {
  display.innerHTML = R1;
}

answered Apr 21, 2015 at 16:36

Hien Luong

5201 gold badge5 silver badges15 bronze badges

Comments

Yuna · Accepted Answer · 2015-04-21 16:40:51Z

1

I tried your code. Besides that you might have missed a closing tag, it worked for me. You need to change these lines:

    if (R1 >= 120 && R1 <= 1000000) {
    display.innerHTML = R1.value;
} else {
    alert("That is an incorrect value please enter one between 120Ohms and 1MOhm.");
}

to:

    if (R1 >= 120 && R1 <= 1000000) {
    display.innerHTML = R1;
} else {
    alert("That is an incorrect value please enter one between 120Ohms and 1MOhm.");
}

you don#t need to get the value of R1, because it already IS hte Value.

I hope i could help. regards

answered Apr 21, 2015 at 16:40

Yuna

1329 bronze badges

Comments

A.J. Uppal · Accepted Answer · 2015-04-21 16:34:21Z

-1

Your problem is that you are never closing your <div> and you also call R1.value, which is basically calling .value on an integer, which is undefined. Try the following:

function R1Value() {
    var R1ValueEntered = prompt("please enter a value for R1:")
    var R1 = parseInt(R1ValueEntered)
    var display = document.getElementById('test3');

    if (R1 >= 120 && R1 <= 1000000) {
        display.innerHTML = R1;
    } else {
        alert("That is an incorrect value please enter one between 120Ohms and 1MOhm.");
    }
}

<button onclick="R1Value()">Change Value</button>
<div id="test3"></div>

answered Apr 21, 2015 at 16:34

A.J. Uppal

19.3k7 gold badges47 silver badges82 bronze badges

2 Comments

Liam Over a year ago

Thank you for this I am sorry it was a simple error on my part, but thank you for the help. Have a nice day! @A.J.

A.J. Uppal Over a year ago

@Liam if this answer helped you, would you mind accepting it? Thanks!

Collectives™ on Stack Overflow

How to display an integer into a div

6 Answers 6

4 Comments

Comments

3 Comments

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

4 Comments

Comments

3 Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related