Java enum getter

Question

I would appreciate any help here.

executing the following code, Buyer2 ID always override buyers1 ID. Means I always get ID=2. I am not sure what is wrong with the following code. I think it is my enum and the get method which always retains the last value.

Buyer bOne = new Buyer("buyer1", 1); 
Buyer bTwo = new Buyer("buyer2", 2);

rest of the code:

public enum Fruits {
    Banana("banana", "B"),
    Apple("apple","A"),
    Orange("orange","O");

    private String type, ID;

    private Fruits(String type, String ID){
        this.type = type;
        this.ID = ID;
    }

    public String getType() {
        return type;
    }

    public String getID() {
        return ID;
    }

    public void setID(String ID){
        this.ID = ID;
    }
}

public class Player {
    private String name;
    private Fruits banana, apple, orange;

    private int ID;

    public buyer(String name, int ID) {
        this.name = name;
        this.ID = ID;
        banana = Fruits.Orange;
        apple = Fruits.Apple;
        orange = Fruits.Orange;

        banana.setID("B"+ID);
        apple.setID("A"+ID);
        Orange.setID="O"+ID;
    }
}

thanks

enum doesn't work like that. With enum, there is only one Apple, only one Banana and only one Orange. Can you describe what you want your code to do? — Misha
– Misha, Commented Apr 26, 2015 at 10:48

Guillaume · Accepted Answer · 2015-04-26 11:10:16Z

1

Your Fruits enum is mutable, which is probably not what you want. The setID() method on Fruits is probably a design error. As the different fruits (Banana, Apple, ...) are a single instance, shared through your all program, they need to reflect some globabl state, not some state specific to the buyer.

Try to remove this setter and see if you can refactor your code ...

answered Apr 26, 2015 at 11:10

Guillaume

19k8 gold badges56 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user2119807 Over a year ago

I guess I need to Look into enums and study them carefully. It sounds like the enums are mostly suitable for constants

Guillaume Over a year ago

There is no problem having mutable state in your enum, but there is only one instance of an enum, so its state is global.

mugiwaradz · Accepted Answer · 2015-04-26 10:48:19Z

0

Fruits.java

package test;

public enum Fruits {

    Banana("banana", "B"), Apple("apple", "A"), Orange("orange", "O");

    private String type, ID;

    private Fruits(String type, String ID) {
        this.type = type;
        this.ID = ID;

    }

    public String getType() {
        return type;
    }

    public void setType(String type) {
        this.type = type;
    }

    public String getID() {
        return ID;
    }

    public void setID(String iD) {
        ID = iD;
    }
}

Buyer.java

   package test;
    public class Buyer {
    private String name;
    private Fruits banana, apple, orange;

    private int ID;


    public Buyer(String name, int ID) {
        this.name = name;
        this.ID = ID;
        banana = Fruits.Orange;
        apple = Fruits.Apple;
        orange = Fruits.Orange;

        banana.setID("B"+ID);
        apple.setID("A"+ID);
        orange.setID("O"+ID);

    }
    public static void main (String  []args){

            Buyer bOne = new Buyer("buyer1", 1); 
    System.out.println("id = " + bOne.ID + " name =" + bOne.name);
    Buyer bTwo = new Buyer("buyer2", 2);
    System.out.println("id = " + bTwo.ID  + " name =" + bTwo.name);
    }
    }

Result on consol :

id = 1 name =buyer1

id = 2 name =buyer2

answered Apr 26, 2015 at 10:48

mugiwaradz

3931 gold badge3 silver badges15 bronze badges

1 Comment

mugiwaradz Over a year ago

Orange.setID="O"+ID; to orange.setID("O"+ID), générate setter & getter and add a main class to test

Olli Zi · Accepted Answer · 2015-04-26 10:48:21Z

0

Maybe check your last line:)

Orange.setID="O"+ID; -> orange.setID="O"+ID;

answered Apr 26, 2015 at 10:48

Olli Zi

3352 silver badges10 bronze badges

1 Comment

DennisW Over a year ago

This is irrelevant; Orange and orange both point to the same (static final) enum constant.

Mohammad Alavi · Accepted Answer · 2015-04-26 10:56:35Z

0

each instance of the enumeration is guaranteed to be constructed exactly once and because of this the last value retains.

answered Apr 26, 2015 at 10:56

Mohammad Alavi

7548 silver badges12 bronze badges

1 Comment

user2119807 Over a year ago

Thanks, I guess I need to Look into enums and study them carefully. It sounds like the enums are mostly suitable for constants

Collectives™ on Stack Overflow

Java enum getter

4 Answers 4

2 Comments

1 Comment

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

1 Comment

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related