cakePHP multidimensional array loop back to previous push

Question

I have created an array which I need to show a list of projects for the current user. Each project is made up of stages, each stage can have multiple KPIs assigned to it.

As you can see the stages are appended to the array fine and for the most part so are the KPIs.

The exception to this is with KPIs that are not stage specific. When I have this type of KPI is should be assigned to the project section, as it spans multiple stages.

KPIs are assigned to stages by the PSID, if the id is null then it is a project wide KPI.

The issue I'm having is with the project wide KPIs. They are repeated, I need each KPI to appear once in the array.

I've tried to check the previously pushed array element with the currently pushed one in order to check.

$i=0;
    foreach($projects as $project){
        $projectStages = $this->ProjectStages->find('all',
                array(
                        'conditions' => array(
                            'pid' => $project['Projects']['pid']
                        )
                )
        );
        array_push($projects[$i], $projectStages);


        $n=0;
        foreach($projectStages as $stage){
            $projectKPIs = $this->ProjectKPIs->find('all',
                    array(
                            'conditions' => array(
                                    'nPid' => $project['Projects']['pid']
                            )
                    )
            );  

            foreach($projectKPIs as $projectKPI){
                if(empty($projectKPI['ProjectKPIs']['nPsid'])){

                    $N = $n-1;
                    $curpkid = $projectKPI['ProjectKPIs']['pkid'];

                    if(isset($projects[$i]['Projects'][$N]['ProjectKPIs']['pkid'])){
                        $prevpkid = $projects[$i]['Projects'][$N]['ProjectKPIs']['pkid'];
                    }else{
                        $prevpkid = null;
                    }

                    if($curpkid != $prevpkid){
                        echo 'cur: '.$curpkid.' - prev: '.$prevpkid;
                        array_push($projects[$i]['Projects'], $projectKPI);
                    }

                }else if($projectKPI['ProjectKPIs']['nPsid'] == $stage['ProjectStages']['psid']){
                    array_push($projects[$i][$i][$n]['ProjectStages'], $projectKPI);
                }

            }



            $n++;
        }


        $i++;
    }

Below is the code I'm using and the array I'm currently getting back:

John McMahon · Accepted Answer · 2015-04-30 02:33:16Z

1

It seems that you are retrieving the same exact database results multiple times. I'm looking at the find in this code block:

    foreach($projectStages as $stage){
            $projectKPIs = $this->ProjectKPIs->find('all',
                    array(
                            'conditions' => array(
                                    'nPid' => $project['Projects']['pid']
                            )
                    )
            ); 

            // ...
    }

It looks to me that you are going to get the same result set for $projectKPIs on each iteration of the foreach $projectStages because the find for ProjectKPIs is using the project id and nothing to do with whatever the current $stage is.

So effectively for every stage you then loop over all the same KPIs again, causing your logic to get convoluted trying to avoid duplicates.

Perhaps this can be simplified by restructuring your foreach loops. I would ditch the outer foreach($projectStages as $stage) and then iterate over all the KPIs only once. Then inside that loop iterate over each stage only when you need to test against the $stage['ProjectStages']['psid'], which may actually be unnecessary at that point.

edited Apr 30, 2015 at 2:33

answered Apr 30, 2015 at 2:27

John McMahon

1,6151 gold badge16 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

jampez77 Over a year ago

Thank you. This led me right to the answer. I simply matched the project KPIs query with the psid and then for the project wide KPIs I ran a separate query to match psid where null

Collectives™ on Stack Overflow

cakePHP multidimensional array loop back to previous push

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related