WebApi Controller model serialization issue

Question

I'm facing little stranger issue with Web API controller. I have a collection which is being passed in an action of api controller. Object being used is collection is having 4 properties.

My action is able to accept collection parameter when it's properties are in specific order. See below :-

    [HttpPost]
    public ForexRates UpdateRates([FromBody] Rates rates)
    {
        // TODO: Obviously code :) 
        return rates;
    }

This code is being place in API controller & calling from Postman. See below:-

<rates>
  <rate> 
   <id>fefef</id>
    <rate>35353.333</rate>
    <series>dfefge</series>
    <series-order>sfefefef</series-order>  
</rate></rates>

If I change the order of the properties I started getting null value in my action. Can some one please explain this :)

Models

public class Rate
{
    public string Id { get; set; }
    public string Date { get; set; }
    public double Rate { get; set; }
}

public class Rates : Collection<ForexRate>
{
}

Please add the implementation of Rate and Rates

Old Fox
– Old Fox

2015-05-06 12:09:02 +00:00
Commented May 6, 2015 at 12:09 — Old Fox
– Old Fox, Commented May 6, 2015 at 12:09
I have added models as well.

ggtffg
– ggtffg

2015-05-07 11:02:46 +00:00
Commented May 7, 2015 at 11:02 — ggtffg
– ggtffg, Commented May 7, 2015 at 11:02

Community · Accepted Answer · 2017-05-23 10:26:55Z

1

You will need to control the order with which your XML is serialized. Use XmlElementAttribute and specify the Order.

There is a similar question here

FYI, I suppose there is no way for you to change the order of the properties, while you supply from PostMan to your WebApi service. You will need to follow the exact order.

If you don't wanna do that, then pass this Xml as a string parameter and then parse it inside a method.

edited May 23, 2017 at 10:26

CommunityBot

11 silver badge

answered May 6, 2015 at 13:33

now he who must not be named.

9,40230 gold badges89 silver badges156 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

fdomn-m · Accepted Answer · 2015-05-07 11:14:59Z

0

The default binder can have issues when the same name is used in different places during binding.

In your case you've got Rate.Rate - both class name and property name. Try changing your class to (and corresponding xml for the post) :

public class Rate
{
    public string Id { get; set; }
    public string Date { get; set; }
    public double Value { get; set; }
}

and then try changing the order.

While I don't have a definitive reason why it works in one order and not another, it's likely that when it gets to the Rate(double) value it tries to create a new Rate(object) but doesn't have the correct properties (as its just a double).

A more complicated solution would be to write a specific model binder for the Rate object.

answered May 7, 2015 at 11:14

fdomn-m

28.8k8 gold badges39 silver badges70 bronze badges

3 Comments

ggtffg Over a year ago

Not actually! The name of my class n property is not same. Models posted here are just dummy names of DTO classes.

ggtffg Over a year ago

Yes creating model binder is alternate solution but still before i try next, i would like to have reason of this situation.

ggtffg Over a year ago

I have created these DTO classes as Data Contracts. May be if that can help to understand .net default serialization behavior

Theo · Accepted Answer · 2015-05-20 19:30:43Z

0

The issue has to do with the DataContractSerializer which expects the elements to occur in a specific order (alphabetical with some consideration given to inheritance). That's the default serializer used when creating a Web API project.

You can override this and specify a different serializer during API Configuration like this:

GlobalConfiguration.Configuration.Formatters.XmlFormatter
  .SetSerializer<SomeType>(new XmlSerializer(typeof(SomeType)));

answered May 20, 2015 at 19:30

Theo

1

Collectives™ on Stack Overflow

WebApi Controller model serialization issue

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related