Add onclick to a tag from javascript

Question

I am creating a form from javascript. I have to put the onclick on the a tag to call a method when clicked. I am doing like this, but it is not appearing the onclick.

function remPass() {
        var log = document.getElementById("login");
        var form = document.createElement('form');
        form.method = "post";
        form.action = "";
        log.appendChild(form);
        var input = document.createElement('input');
        input.type = "text";
        input.name = "username";
        input.className = "username";
        input.placeholder = "Usuario";
        var a = document.createElement('a');
        a.className = "bt-enter pink";
        a.id = "recordar";
        a.href = "#";
        a.onclick = "remember()"; //Here is the problem
        a.innerHTML = "Recordar contraseña";
        form.appendChild(input);
        form.appendChild(a);
    }

if remember() is a function, why is it a string? remove the " " around remember() — NachoDawg
– NachoDawg, Commented May 8, 2015 at 8:44
how about adding the "HTML code" instead of creating the form element from scratch? — Wreeecks
– Wreeecks, Commented May 8, 2015 at 8:45
@Asier GR, if you want to attached onclick event method, setAttribute would be sufficient. — Parkash Kumar
– Parkash Kumar, Commented May 8, 2015 at 8:54

Katya Pavlenko · Accepted Answer · 2015-05-08 08:45:20Z

5

You need use method, not method's result nor a string

a.onclick = remember;

And don't forget to create

function remember(){
  //some code
}

answered May 8, 2015 at 8:45

Katya Pavlenko

3,4033 gold badges19 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Asier GR Over a year ago

And what if you want to call a function with some parameter?

Katya Pavlenko Over a year ago

if you write remember(param1, param2), when it's called by click, param1 would be event object and second would be undefined. also you can call this function by yourself, passing any parameters you like to

Apurva Ojas · Accepted Answer · 2015-05-08 08:45:10Z

4

the correct way of doing is like that

  a.onclick = remember; //do like that

  var remember = function(){
           //remember logic..
  };

answered May 8, 2015 at 8:45

Apurva Ojas

3311 silver badge5 bronze badges

Comments

Arshad Rehmani · Accepted Answer · 2015-05-08 08:47:05Z

2

the right way is

  a.onclick = remember; //without double quotes

  var remember = function(){
           //more code here...
  };

answered May 8, 2015 at 8:47

Arshad Rehmani

2,1935 gold badges26 silver badges46 bronze badges

Comments

Parkash Kumar · Accepted Answer · 2015-05-08 08:51:53Z

1

You should use setAttribute method to set attributes / properties for the tag while creating it:

var a = document.createElement('a');
    a.setAttribute("class", "bt-enter pink");
    a.setAttribute("id", "recordar");
    a.setAttribute("href", "#");
    a.setAttribute("onclick ", "remember();");
    a.innerHTML = "Recordar contraseña";

This is the most competent method of creating elements cross-browser.

edited May 8, 2015 at 8:51

answered May 8, 2015 at 8:45

Parkash Kumar

4,7303 gold badges25 silver badges39 bronze badges

Comments

Fourat · Accepted Answer · 2015-05-08 08:51:27Z

0

You should give something of type function not a string:

a.onclick = remember;
//....
var remember = function() {
// remember logic
}

answered May 8, 2015 at 8:51

Fourat

2,4476 gold badges41 silver badges60 bronze badges

Collectives™ on Stack Overflow

Add onclick to a tag from javascript

5 Answers 5

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related