Making one function instead of two

Question

I have two functions:

public List<string> getAllProperties1()
{
    List<string> output = new List<string>();
    foreach (MyItem item in getItems())
    {
        if (!output.Contains(item.property1) &&
            item.property1 != null)
        {
            output.Add(item.property1);
        }
    }
    return output;
}

public List<string> getAllProperties2()
{
    List<string> output = new List<string>();
    foreach (MyItem item in getItems())
    {
        if (!output.Contains(item.property2) &&
            item.property2 != null)
        {
            output.Add(item.property2);
        }
    }
    return output;
}

I renamed functions, items and properties to make things more simple. What I want to do is one function, may be even more simple - instead of these two. How to achieve this?

Property1 and Property 2 are both string properties.

possible duplicate of Get property value from C# dynamic object by string (reflection?) — Cwt
– Cwt, Commented May 12, 2015 at 7:39
@TimSchmelter This code has been stripped of context (placeholder names being used instead of the real values) which makes it off-topic as "example code" on CR. — Simon Forsberg
– Simon Forsberg, Commented May 12, 2015 at 10:56

Tim Schmelter · Accepted Answer · 2015-05-12 07:41:07Z

4

Do you really need methods for this:

List<string> allUniqueProp1 = getItems()
    .Select(x => x.property1)
    .Where(s => s != null)
    .Distinct()
    .ToList();

The same with property2 and you are done

answered May 12, 2015 at 7:41

Tim Schmelter

462k79 gold badges719 silver badges980 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

General-Doomer · Accepted Answer · 2015-05-12 07:39:36Z

1

Code:

public List<string> getAllProperties(Func<MyItem, string> func)
{
    List<string> output = new List<string>();
    foreach (MyItem item in getItems())
    {
        string value = func(item);
        if (!output.Contains(value) &&
            value != null)
        {
            output.Add(value);
        }
    }
    return output;
}

Usage:

getAllProperties(e => e.property1);

answered May 12, 2015 at 7:39

General-Doomer

2,76115 silver badges13 bronze badges

Comments

James Lucas · Accepted Answer · 2015-05-12 07:40:34Z

1

Use a Func as a strategy to acquire comparison property and call from a single method:

public List<string> GetAll(Func<MyItem, string> propertyGetter)
{
    List<string> output = new List<string>();
    foreach (MyItem item in getItems())
    {
        var value = propertyGetter(item);
        if (!output.Contains(value) && value != null)
        {
            output.Add(value);
        }
    }
    return output;
}

Then to use:

GetAll(item => item.Property1);
GetAll(item => item.Property2);

answered May 12, 2015 at 7:40

James Lucas

2,53212 silver badges15 bronze badges

Collectives™ on Stack Overflow

Making one function instead of two

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related