Optimising Jquery Code

Question

I'm using a jquery smart wizard script to make my forms into wizards.

This works very well, but the validation code looks like it could be made simpler.

This is the example they provide. Could this be made into a loop so I don't have to write it for each of my 5 steps ?

function validateSteps(step){
  var isStepValid = true;
   if(step == 1){
    if(validateStep1() == false ){
      isStepValid = false; 
      $('#wizard').smartWizard('showMessage','Please correct the errors in step '+step+ ' and click next.');
      $('#wizard').smartWizard('setError',{stepnum:step,iserror:true});         
    }else{
      $('#wizard').smartWizard('hideMessage');
      $('#wizard').smartWizard('setError',{stepnum:step,iserror:false});
    }
}

    if(step == 3){
     if(validateStep3() == false ){
       isStepValid = false; 
       $('#wizard').smartWizard('showMessage','Please correct the errors in step '+step+ ' and click next.');
       $('#wizard').smartWizard('setError',{stepnum:step,iserror:true});         
     }else{
       $('#wizard').smartWizard('hideMessage');
       $('#wizard').smartWizard('setError',{stepnum:step,iserror:false});
     }
    }

    return isStepValid;
 }

Thanks

For optimizing you need to show how validateStep1() and validateStep2() , ..... so on, looks like! so can generalize it. — Dhaval Marthak
– Dhaval Marthak, Commented May 13, 2015 at 9:21
@GuruprasadRao Sad to say it but, "This is the example they provide." indicates that the OP did not write this code himself which makes it off-topic for Code Review. — Simon Forsberg
– Simon Forsberg, Commented May 13, 2015 at 9:31
I agree @SimonAndréForsberg. Well he can remove it though!! :) — Guruprasad J Rao
– Guruprasad J Rao, Commented May 13, 2015 at 9:32

Su4p · Accepted Answer · 2015-05-13 09:27:08Z

1

You could do this,

function validateSteps(){
        var isStepValid = true, step =1;
        for(step ;step <=5;step ++){
            if(window["validateStep"+step ]() == false ){
              isStepValid = false; 
              $('#wizard').smartWizard('showMessage','Please correct the errors in step '+step + ' and click next.');
              $('#wizard').smartWizard('setError',{stepnum:step ,iserror:true});         
            }else{
              $('#wizard').smartWizard('hideMessage');
              $('#wizard').smartWizard('setError',{stepnum:step ,iserror:false});
            }

        }
        return isStepValid;

    }

You just have to worry about having a function named validateStepX

answered May 13, 2015 at 9:27

Su4p

86510 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Tom Over a year ago

Thanks that seems to help

Collectives™ on Stack Overflow

Optimising Jquery Code

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related