do while loop doesn't get out of the loop?

Question

I'm pretty sure this should work... But even if I enter a 0 or a 1 it still asks me to pick a colour. Am I being stupid or should it be exiting the loop if I enter a 0 or a 1?

public static int setColour() {
    EasyReader keyboard = new EasyReader();
    int colour;
    do{
        colour = keyboard.readInt("Pick a colour (black = 0, white = 1): ");
    }while (colour != 0 || colour != 1);
    return colour;
}

You need and (&&), not or (||)

Mark Leiber
– Mark Leiber

2015-05-13 23:30:34 +00:00
Commented May 13, 2015 at 23:30 — Mark Leiber
– Mark Leiber, Commented May 13, 2015 at 23:30
read online about conditional operators.

Vinayak Pingale
– Vinayak Pingale

2015-05-13 23:43:30 +00:00
Commented May 13, 2015 at 23:43 — Vinayak Pingale
– Vinayak Pingale, Commented May 13, 2015 at 23:43

Reimeus · Accepted Answer · 2015-05-13 23:30:32Z

7

Both conditions will never be satisfied simultaneously using the || operator. You want

} while (colour != 0 && colour != 1);

answered May 13, 2015 at 23:30

Reimeus

160k16 gold badges225 silver badges282 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ChatNoir Over a year ago

Oh, for some reason I thought using && meant 0 AND 1 to make it exit the loop and || meant either 0 OR 1 to exit the loop.. But thanks! :)

Javon Wilson · Accepted Answer · 2015-05-14 00:37:59Z

0

Using || will never return the correct result. The && operator however will return your answer accurate.

answered May 14, 2015 at 0:37

Javon Wilson

11 bronze badge

Collectives™ on Stack Overflow

do while loop doesn't get out of the loop?

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related