L5: Call to a member function function() on a non-object

Question

Got a resourceful controller with a __contruct function to declare $project

 public function __construct(Project $project){

    $this->project = $project;
}

Then I have an update and a destroy function which gives an Call to a member function delete() on a non-object (or update() error)

 public function edit($id)
{
    $project = $this->project->find($id);
    return view('project.edit', ['project' => $project, 'id' => 'edit']);
}


public function update(CreateProjectRequest $request, $project)
{
    $project->fill($request->input())->save();

    return redirect('project/index');
}


public function destroy($project)
{
    $project->delete();
    return redirect('project');
}

What am I doing wrong?

I actually just noticed I had a return $project there, I deleted it now but it doesn't fix the problem — Leguam
– Leguam, Commented May 15, 2015 at 8:22

lukasgeiter · Accepted Answer · 2015-05-15 08:31:11Z

4

$project in this case is just the id of the project. You have to load it first:

public function destroy($projectId)
{
    $project = $this->project->findOrFail($projectId);
    $project->delete();
    return redirect('project');
}

Or just use the destroy method which takes the key as parameter:

public function destroy($projectId)
{
    $this->project->destroy($projectId);
    return redirect('project');
}

You might also want to look into Route Model Binding to fetch the model automatically from the DB.

edited May 15, 2015 at 8:31

answered May 15, 2015 at 8:23

lukasgeiter

154k29 gold badges349 silver badges280 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

L5: Call to a member function function() on a non-object

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related