String concatenation of interpolated variables

Question

The code below is longer than the recommended 80 characters.

I've tried to break it up and concatenate it with + operator and << operator, but it doesn't seem to work. I've tried the .to_s method and moved the colons into their own string but to no avail.

What would be the correct way to split this up onto 2 or 3 lines without getting the no method "+@":String error?

string = "#{sprintf("%02i", hours)}:#{sprintf("%02i", minutes)}:#{sprintf("%02i", seconds)}"

If you would have a Time object instead of your hour, minute, second integers, you could use time.strftime(%H:%M:%S). — Holger Just
– Holger Just, Commented May 16, 2015 at 18:49
I tried this but I dont think time is part of ruby so it gave me an error saying time wasnt defined. — Jeff
– Jeff, Commented May 17, 2015 at 19:24

Yu Hao · Accepted Answer · 2015-05-16 18:45:34Z

5

You can combine the three sprintf into one:

string = sprintf("%02i:%02i:%02i", hours, minutes, seconds)

answered May 16, 2015 at 18:45

Yu Hao

123k50 gold badges253 silver badges305 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Andrey Deineko Over a year ago

NOT the answer to question

Yu Hao Over a year ago

@AndreyDeineko If the question is a general how to split a line that includes string interpolated variables into multiple lines, you are right. However, it's not, in this specific problem, the line is long because OP's code uses unnecessary string interpolation.

Jeff Over a year ago

Okay thanks for this, I could learn from this because I forgot sprintf was essentially the same as printf in java

Andrey Deineko · Accepted Answer · 2015-05-16 18:43:44Z

1

To split string into multiline in Ruby you use backslash:

string = "#{sprintf("%02i", hours)}: \
#{sprintf("%02i", minutes)}: \
#{sprintf("%02i", seconds)}"

Notice how there is only one opening and one closing ".

You can also consider moving three calls to sprintf method into one.

answered May 16, 2015 at 18:43

Andrey Deineko

52.5k11 gold badges119 silver badges151 bronze badges

3 Comments

Andrey Deineko Over a year ago

why minus? it is the answer to OP question. who did it? :)

Jeff Over a year ago

what exactly happens to the space between that colon and the backslash? Is all the white space just removed due to the \?

Andrey Deineko Over a year ago

@Jeff if you put backslash without a space after :, there will be no space

Cary Swoveland · Accepted Answer · 2015-05-18 02:02:54Z

0

I'm guessing that your real question is that, given numbers of seconds or a time object, you want to construct a string with the desired format.

If you are given seconds:

def fmt(seconds)
  hours, minutes = seconds.divmod(60)
  "%02d, %02d, %02d" % [hours, *minutes.divmod(60)]
end

fmt(223)
  #=> "03, 00, 43"

If you are given a Time object:

require 'time'

def fmt(time)
  time.strftime('%H hours, %M minutes, %S seconds')
end

time = Time.now
  #=> 2015-05-16 14:38:02 -0700 
fmt(time)
  #=> "14 hours, 38 minutes, 02 seconds"

In this second case I added the words "hours", "minutes" and "seconds" just to illustrate how the format string could be modified.

If you want to print this on multiple lines, simply insert newlines (\n) in the appropriate format string.

edited May 18, 2015 at 2:02

answered May 16, 2015 at 19:06

Cary Swoveland

111k6 gold badges69 silver badges105 bronze badges

2 Comments

Jeff Over a year ago

Just a quick question. Im not understanding why you do hours,minutes = seconds.divmod(6). The six there isnt making mathematical sense to me..

Cary Swoveland Over a year ago

Thanks for spotting that, Jeff. It should have been 60.

Collectives™ on Stack Overflow

String concatenation of interpolated variables

3 Answers 3

3 Comments

3 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

3 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related