Batch Reading File into Variable not working

Question

I am trying to redirect command output to variable using file as intermediary. I am able to redirect command output to file and but unable to read content of file into variable.

Batch File Script

echo off

pushd C:\Software
set TEMP_DIR=C:\Users\prade\Softwares

for /D %%i in (*) do (
    pushd "%%i"
    echo %TIME% > %TEMP_DIR%\a.log
    type %TEMP_DIR%\a.log
    for /f "delims=" %%x in (%TEMP_DIR%\a.log) do set duration=%%x
    echo %%i  %duration%
    popd
)
popd
echo on

I gives me below output

C:\Users\prade>echo off
 7:36:47.86
AutoHotKey
 7:36:47.86
cygwin64
 7:36:47.86
ffmpeg-20150518-git-451be67-win64-static
 7:36:47.86
mtn-200808a-win32
 7:36:47.86
ProcessExplorer
 7:36:47.86
tools

As you see there is nothing after directory name but type giving me content of file.

If I echo %duration% after batch file terminate in same cmd window, it gives me last time back.

What I am doing wrong?

@Stephan, Thanks. There is always something new stuff to learn. :) — kr.pradeep
– kr.pradeep, Commented May 20, 2015 at 12:08
@Stephan, does that mean I should use ! all the time instead of %, is there any harm, performance impact of using ! instead of % something like that? — kr.pradeep
– kr.pradeep, Commented May 20, 2015 at 15:29
Found this link that explain what setlocal enableDelayedExpansion do. Based on that I assume it should be used all the time, unless we have specific need to expand at parse time. Correct? — kr.pradeep
– kr.pradeep, Commented May 20, 2015 at 15:42
No, just the other was round: use delayed variables only, if you have specific need to expand at execution time. There are some interesting links in the answers and comments of this question — Stephan
– Stephan, Commented May 20, 2015 at 15:45

npocmaka · Accepted Answer · 2015-05-20 12:07:34Z

1

@echo off

pushd C:\Software
set "TEMP_DIR=C:\Users\prade\Softwares"

setlocal enableDelayedExpansion
for /D %%i in (*) do (
    pushd "%%i"
    echo %TIME% > "%TEMP_DIR%\a.log"
    type %TEMP_DIR%\a.log
    for /f "usebackq delims=" %%x in ("%TEMP_DIR%\a.log") do set "duration=%%x"
    echo %%i  !duration!
    popd
)
popd
echo on

answered May 20, 2015 at 12:07

npocmaka

57.8k19 gold badges162 silver badges199 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

MichaelS · Accepted Answer · 2015-05-20 12:07:58Z

1

Add SETLOCAL EnableDelayedExpansion just below ECHO OFF and access duration with !duration! instead of %duration%.

answered May 20, 2015 at 12:07

MichaelS

6,0727 gold badges33 silver badges47 bronze badges

Collectives™ on Stack Overflow

Batch Reading File into Variable not working

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related