Dynamically select variable in for loop

Question

This seems very simple but I'm not understanding how to do this and haven't figured out how to phrase it for Google. I have a set of 12 ImageViews declared in XML, so I want to declare them all in a for loop, using something like

for(int i = 1; i < 13; i++) {
    ImageView moles[i] = FindViewById(R.id.mole + i);
}

But I'm not understanding how to declare the argument for FindViewById.

You can't, unless you use reflection, which you don't want to. Is there some Android API that lets you pass the ID as a string instead? — Stack Exchange Broke The Law
– Stack Exchange Broke The Law, Commented May 21, 2015 at 1:22

Gabe Sechan · Accepted Answer · 2015-05-21 01:31:57Z

1

Generally you make a hard coded array of ids

int ids[] = {R.id.image1, R.id.imag2,...};
for(int i = 0; i < ids.size; i++) {
    ImageView moles[i] = FindViewById(ids[i]);
}

answered May 21, 2015 at 1:31

Gabe Sechan

94.8k9 gold badges92 silver badges135 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Izold Tytykalo · Accepted Answer · 2015-05-21 01:31:21Z

1

R.id.mole is dynamically generated by Android SDK. It is int, right, but you can't use as int because next one is not necessary previous+1.

If you use ids dynamically generated then assume they are random.

answered May 21, 2015 at 1:31

Izold Tytykalo

7191 gold badge5 silver badges15 bronze badges

Comments

Bidhan · Accepted Answer · 2015-05-21 01:35:12Z

1

You can't do that. But the closest you can get is by doing this

private static final int[] imageArray = {R.id.mole1, R.id.mole2, R.id.mole3, R.id.mole4, R.id.mole5};
private ImageView[] moles= new ImageView[idArray.length];

Then your for loop would look something like this

for (int i=1; i<=imageArray.length; i++) {
    moles [i] = (ImageView)findViewById(idArray[i]); // Fetch the view id from array
    ....
}

edited May 21, 2015 at 1:35

answered May 21, 2015 at 1:32

Bidhan

10.7k3 gold badges42 silver badges51 bronze badges

1 Comment

Gabe Sechan Over a year ago

The final isn't needed, unless you want to pass the index to a Listener you declare inside this loop. You can just use i

Collectives™ on Stack Overflow

Dynamically select variable in for loop

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related