Show/hide text with simple inline code

Question

I am trying to code a simple click to read more within a paragraph. I am sure this code worked to both show AND hide on click. When I try this now, it shows the hidden text, but will not hide it when I click again?

<div onclick="document.getElementById ('review').style.display=document.getElementById

('review').style.display='none' ? 'block':'none';">

<p>Click here to read our review</p>

<div id="review" style="display: none;">Review text goes here.</div>

Any ideas about how to achieve this with simple inline code?

Thanks

You are assigning 'none', need a double-equals in your ternary operator to test for 'none' — swornabsent
– swornabsent, Commented May 21, 2015 at 14:26
Not sure you get me, I'm saying this line: document.getElementById('review').style.display='none' ? 'block':'none' is ASSIGNING the value 'none' with the single-equals, which will always be true and set 'block', you need a double- (or triple-) equals there: document.getElementById('review').style.display=='none' ? 'block':'none' — swornabsent
– swornabsent, Commented May 21, 2015 at 14:59

Pugazh · Accepted Answer · 2015-05-21 14:28:03Z

1

Try this https://jsfiddle.net/muwyu286/. You have used an assign = instead of == in ('review').style.display='none' ? 'block':'none';"

<div onclick="document.getElementById('review').style.display = document.getElementById('review').style.display == 'none' ? 'block':'none';">
    <p>Click here to read our review</p>
    <div id="review" style="display: none;">Review text goes here.</div>

answered May 21, 2015 at 14:28

Pugazh

9,5715 gold badges36 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 11:58:09Z

0

You can look at this to learn about toggling through jquery.

Toggle Text with jQuery

edited May 23, 2017 at 11:58

CommunityBot

11 silver badge

answered May 21, 2015 at 14:28

user2828274

311 silver badge5 bronze badges

Collectives™ on Stack Overflow

Show/hide text with simple inline code

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related