PowerShell no longer reads input from textbox

Question

Last time I ran this script was 2 years ago, and I thought maybe I'm not transferring $userInput back to main program, but even the function doesn't read $userInput.

How to troubleshoot?

function getValues($formTitle, $textTitle){


    [void] [System.Reflection.Assembly]::LoadWithPartialName("System.Drawing") 
    [void] [System.Reflection.Assembly]::LoadWithPartialName("System.Windows.Forms") 


    $objForm = New-Object System.Windows.Forms.Form
    $objForm.Text = $formTitle
    $objForm.Size = New-Object System.Drawing.Size(300,200)
    $objForm.StartPosition = "CenterScreen"

    $objForm.KeyPreview = $True
    $objForm.Add_KeyDown({if ($_.KeyCode -eq "Enter") {$x=$objTextBox.Text;$objForm.Close()}})
    $objForm.Add_KeyDown({if ($_.KeyCode -eq "Escape") {$objForm.Close()}})

    $OKButton = New-Object System.Windows.Forms.Button
    $OKButton.Location = New-Object System.Drawing.Size(75,120)
    $OKButton.Size = New-Object System.Drawing.Size(75,23)
    $OKButton.Text = "OK"
    $OKButton.Add_Click({$userInput=$objTextBox.Text;$objForm.Close()})
    $objForm.Controls.Add($OKButton)

    $CANCELButton = New-Object System.Windows.Forms.Button
    $CANCELButton.Location = New-Object System.Drawing.Size(150,120)
    $CANCELButton.Size = New-Object System.Drawing.Size(75,23)
    $CANCELButton.Text = "CANCEL"
    $CANCELButton.Add_Click({$objForm.Close()})
    $objForm.Controls.Add($CANCELButton)

    $objLabel = New-Object System.Windows.Forms.Label
    $objLabel.Location = New-Object System.Drawing.Size(10,20)
    $objLabel.Size = New-Object System.Drawing.Size(280,30)
    $objLabel.Text = $textTitle
    $objForm.Controls.Add($objLabel)

    $objTextBox = New-Object System.Windows.Forms.TextBox
    $objTextBox.Location = New-Object System.Drawing.Size(10,50)
    $objTextBox.Size = New-Object System.Drawing.Size(260,20)
    $objForm.Controls.Add($objTextBox)

    $objForm.Topmost = $True

    $objForm.Add_Shown({$objForm.Activate()})

    [void] $objForm.ShowDialog()

    write-host user Input is $userInput
    return $userInput


}


$schema = getValues "Database Schema" "Enter database schema"
$db_IP = getValues "Database Server" "Enter IP address where database is located"
$init_cat = getValues "Database Name" "Enter database name "
$userID = getValues "Database Administrator Username" "Enter username of database administrator"

Output is

user Input is
user Input is
user Input is
user Input is

UPDATE

When I try code from https://technet.microsoft.com/en-us/library/ff730941.aspx and add write-host $x, there is no output

PowerShell version 4.0

@Erti-ChrisEelmaa No luck. And worse part is, I am trying code from technet.microsoft.com/en-us/library/ff730941.aspx and when I add write-host $x, nothing is output — Glowie
– Glowie, Commented May 21, 2015 at 17:08

Mathias R. Jessen · Accepted Answer · 2015-05-21 17:17:34Z

3

Last time I ran this script was 2 years ago

As of PowerShell version 3.0, the scope of the delegate invoked by an event handler such as

$OKButton.Add_Click({$userInput=$objTextBox.Text;$objForm.Close()})

is distinct from the containing script, meaning that when you assign something to $userInput inside the Add_Click scriptblock, you're actually assigning something to a variable that is local to that scriptblock.

The fix is to explicitly state a parent-scope, like this:

$OKButton.Add_Click({$Script:userInput=$objTextBox.Text;$objForm.Close()})

It's the same behavior that causes the TechNet example to not run correctly in PowerShell 4.0 - unless you substitute all inline mentions of $x with $Script:x or $Global:x

You can read more about the dynamic scoping model in PowerShell (and how variables initialized in a child scope may end up hiding variables sharing their name in a parent scope) in the about_Scopes helpfile:

Get-Help about_Scopes -Full

edited May 21, 2015 at 17:17

answered May 21, 2015 at 17:16

Mathias R. Jessen

178k13 gold badges175 silver badges234 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Mathias R. Jessen Over a year ago

Yes. I believe this change in behavior is actually a "fix", and that the authors of the original WinForm snippet in TechNet magazine may have been a little too excited about their cool working example to check whether they were abusing something in PowerShell 1.0

Tony Hinkle · Accepted Answer · 2015-05-21 17:09:36Z

1

I've never done anything with forms before, but making the $userInput assignment to $objTextBox.Text after the ShowDialog() worked for me:

[void] $objForm.ShowDialog()
$userInput = $objTextBox.Text
write-host user Input is $userInput

answered May 21, 2015 at 17:09

Tony Hinkle

4,7627 gold badges25 silver badges35 bronze badges

5 Comments

Glowie Over a year ago

It works, but I'm wondering, why didn't previous code work. Even script on MS's official website is not working???

Tony Hinkle Over a year ago

My educated guess here is that something has changed since Powershell 1.0 that broke their sample script.

Mathias R. Jessen Over a year ago

@TonyHinkle yup, he's been "scoped" ;)

Tony Hinkle Over a year ago

@MathiasR.Jessen Thanks for taking the time to give us the scoop on the scope. I suspected something like that, but I don't know Powershell well enough to know how to use the $Script:variable trick. I've used globals before, but that's a new one I learned today.

Mathias R. Jessen Over a year ago

My pleasure :) I think the most "correct" way would be to access the direct parent scope from the event delegate, like: Set-Variable -Name userInput -Scope 1 -Value $objTextBox.Text, but it becomes unreadable really fast. I think the Script scope is a sensible boundary for what OP describes

Collectives™ on Stack Overflow

PowerShell no longer reads input from textbox

UPDATE

2 Answers 2

1 Comment

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

UPDATE

2 Answers 2

1 Comment

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related