Using Javascript function argument as elementId

Question

I know there are loads of questions similar to this, but I can't find the answer I'm looking for among them.

Probably super simple: I have a very basic JS function, and it has a single argument passed to it. I just want the function to recognise that argument when used in the document.getElementById as the ID.

HTML

<div id="figure1" onmouseover="popup(figure1)"><div class="hide"> TEST </div></div>

JS Function

<script>
function popup(fig) {
    var setnow = document.getElementById( fig );
    setnow.className = "show";
}
</script>

I have tested it without using the argument, i.e.:

<script>
function popup() {
    var setnow = document.getElementById("figure1");
    setnow.className = "show";
}
</script>

... and it works as expected.

I don't use JS ever, so probably this is very simple. :-)

Why downvote? If someone asks a stupid question, that makes them novice, not worthy of a downvote...I am not a javascripter, I just needed a little help, and I did look first. — asimovwasright
– asimovwasright, Commented May 22, 2015 at 7:24

jcubic · Accepted Answer · 2015-05-22 07:20:58Z

3

You need to quote the argument:

<div id="figure1" onmouseover="popup('figure1')"><div class="hide"> TEST </div></div>

Also if you want to get the same element you can use this, then you will not need to use getElementById:

<div id="figure1" onmouseover="popup(this)"><div class="hide"> TEST </div></div>

function popup(el) {
    el.className = "show";
}

edited May 22, 2015 at 7:20

answered May 22, 2015 at 7:18

jcubic

67.1k58 gold badges252 silver badges466 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

asimovwasright Over a year ago

That is correct! Can't believe I didn't test that myself :-) I will mark the answer as correct in 10 mins.

Sylvia Stuurman · Accepted Answer · 2015-05-22 07:20:35Z

1

In an eventhandler, you can use this to denote the element:

<script>
function popup() {
  this.className = "show";
}
</script>

answered May 22, 2015 at 7:20

Sylvia Stuurman

1374 bronze badges

Collectives™ on Stack Overflow

Using Javascript function argument as elementId

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related