PHP MySQL multiple rows not working

Question

I have this code for sending mails to users from DB, but mail is always sent just to first user, even if changing order. (request is sent from AJAX)

    $headers = ...

    $mailbody = ...

    $sql = 'SELECT `email`, `name` FROM `users`'; 
    $result = mysqli_query($link, $sql) or die(mysqli_error($link));

    while ($row = mysqli_fetch_array($result)) {
            $rows[] = $row;
            }

    foreach ($rows as $row) {
            if (mail($row['email'],"title", $mailbody, $headers)) {
            echo 'mail '.$row['name'].' OK';
            return TRUE;
          } else {
            echo 'MAIL ERROR!!!';
            return FALSE;
          }
    }

You're returning from the function after you send the first mail. — Barmar
– Barmar, Commented May 26, 2015 at 9:04

Barmar · Accepted Answer · 2015-05-26 09:05:22Z

1

It's because you do return TRUE after the first successful mail. That ends the function. Take out that line, and put it after the foreach is done.

answered May 26, 2015 at 9:05

Barmar

789k57 gold badges555 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

david8 Over a year ago

Thanks everyone for help! Worked!

Med · Accepted Answer · 2015-05-26 09:04:45Z

0

return TRUE; and return FALSE; stop the foreach loop.

answered May 26, 2015 at 9:04

Med

2,06322 silver badges32 bronze badges

Comments

Blue · Accepted Answer · 2015-05-26 09:04:57Z

It's because of this line: return TRUE;. It's causing your function/script to end right there, instead of continuing with the foreach loop.

If you want the script to stop on the first failure, this should work:

$sql = 'SELECT `email`, `name` FROM `users`'; 
$result = mysqli_query($link, $sql) or die(mysqli_error($link));

while ($row = mysqli_fetch_array($result)) {
        $rows[] = $row;
        }
foreach ($rows as $row) {
        if (mail($row['email'],"title", $mailbody, $headers)) {
        echo 'mail '.$row['name'].' OK';
      } else {
        echo 'MAIL ERROR!!!';
        return FALSE;
      }
}
return TRUE;

It will return true if all the emails have been sent sucessfully, otherwise it will return false on the first failure.

Mohamed Belal · Accepted Answer · 2015-05-26 09:08:14Z

0

Because you use return true or false the foreach loop stop remove it and try again or you can wrap it in a function and then if success return true (after the foreach loop) else return false

answered May 26, 2015 at 9:08

Mohamed Belal

6227 silver badges11 bronze badges

Collectives™ on Stack Overflow

PHP MySQL multiple rows not working

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related