JS: looping function through checkbox array not counting properly

Question

I want to validate the input on a series of checkboxes. There must be at least one checkbox selected, otherwise the user gets an alert to select one. However, the alert appears unless all of the checkboxes are selected.

I realize that the issue is how my for loop params are set, but I cannot figure out how to fix it.

for(var i=0;i<7;i++){
    if( !checkboxes[i].checked ){
        alert( 'You need to select at least one day!');
        checkboxes[i].focus();
        return false;
    }
}

Basically, what you're doing is looping through all the checkboxes, and immediately doing alert('You need to select at least one day!'); the moment any of the checkboxes are not checked. — Huey
– Huey, Commented Jun 1, 2015 at 3:49

Arun P Johny · Accepted Answer · 2015-06-01 03:48:56Z

3

You can use a flag to set the validation status and set it to true if atleast 1 item is checked.

Then after the loop check whether the flag is set else there are no checkboxes selected.

var valid = false;
for (var i = 0; i < checkboxes.length; i++) {
    if (checkboxes[i].checked) {
        valid = true;
        break;
    }
}

if (!valid) {
    alert('You need to select at least one day!');
    checkboxes[0].focus();
    return false;
}

answered Jun 1, 2015 at 3:48

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user2654953 Over a year ago

Thanks Arun. Worked like a charm! I guess as I get more experience with the language I will be able to better understand how to figure out these types of challenges.

PhilVarg · Accepted Answer · 2015-06-01 03:51:26Z

1

You want to do the opposite of what you're coding. your current code flashes the alert if the current checkbox is not checked, that is, if ANY checkbox is not checked. you can modify it to something like this:

var isChecked = false;
for(var i=0;i<7;i++){
    if( checkboxes[i].checked ){
      isChecked = true;
    }
}

if ( !isChecked ) {
    alert( 'You need to select at least one day!');
    checkboxes[0].focus();
    return false;
}

answered Jun 1, 2015 at 3:51

PhilVarg

4,8303 gold badges22 silver badges39 bronze badges

Comments

Siamak Ferdos · Accepted Answer · 2015-06-01 03:57:04Z

1

    var clicked = false;
    $(".CheckBoxClass").each(function () {            
        if($(this).checked ) clicked = true;
     }
     if(clicked)
        return true;
     else ...

edited Jun 1, 2015 at 3:57

answered Jun 1, 2015 at 3:51

Siamak Ferdos

3,3096 gold badges35 silver badges60 bronze badges

Collectives™ on Stack Overflow

JS: looping function through checkbox array not counting properly

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related