Some problem with regex

Question

hello all in my site users can insert data using tabular format. that table can be of any style. but im using regex to give those tables a standard format of our site.but when im using regex it works well but it is removing colspan. but i need colspan widout it tables looks very odd. will anyone please tell me wats wrong with my regex?? following is my regex codes:

$table=eregi_replace("<table[^>]*>","<table  width='100%' border='0' cellspacing='0' cellpadding='0' class='tabularData'>", $table);
$table= preg_replace('/style\s*=\s*(\'|").+(\'|")/i', '', $table);
$table= preg_replace('/bgcolor\s*=\s*(\'|").+(\'|")/i', '', $table);
$table=eregi_replace("<span[^>]*>","",$table);

thanks in advance :)

And mixing ereg and preg functions together is even more ew. — BoltClock
– BoltClock, Commented Jun 17, 2010 at 9:36

Frankie · Accepted Answer · 2010-06-17 15:04:54Z

1

You can easily style the tables with Javascript. In fact you should. Having a regex run like that over users code can lead to security problems if the user figures out your regex (and if you fail to implement it properly; which will probably be the case).

// jquery table styling example (picks up all tables)
$('table').css({
    'width': '100%',
    'background-color': '#F00'
});

Hope it helps!

edited Jun 17, 2010 at 15:04

answered Jun 17, 2010 at 9:39

Frankie

25.2k10 gold badges84 silver badges127 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

simendsjo Over a year ago

Not just security problems. The code will likely have bugs and be hell to maintain

Frankie Over a year ago

@Sam Thanks! with would be a nice if/else feature to have in CSS, though! :)

Marcis · Accepted Answer · 2010-06-17 15:08:42Z

1

Don't use regular expressions where is no need do to that. Use DOM to parse this.

answered Jun 17, 2010 at 15:08

Marcis

4,61727 silver badges24 bronze badges

Collectives™ on Stack Overflow

Some problem with regex

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related