Variable from for loop always returns 0

Question

I am reasonably new to node.js / sails.js and have run into a problem that I know the answer is simple but I cannot seem to work it out.

My code is as follows

SendCompleted : function(req,res)
    {
        var updated = 0;
        var params = req.params.all();
        var dt = JSON.parse(decodeURI(params.id));
        var connection = new sql.Connection(testrmis, function (err)
        {
            if (err) {

            }
            for(var i = 0; i < dt.length; i++) {
                var obj = dt[i];
                var request = new sql.Request(connection);
                request.stream = true;
                request.input('branchid', sql.Int(), obj.branch_id);
                request.input('picklistid', sql.Int(), obj.picklist_id);
                request.input('scanned',sql.Int(),obj.scanned);
                request.input('expected', sql.Int(),obj.expected);
                request.input('poscode', sql.VarChar(),obj.poscode);
                request.input('label', sql.VarChar(), obj.label);
                request.input('dt', sql.VarChar(), obj.dt);
                request.execute('WAREHOUSE_InsertPiPackData');
                request.on('done', function(returnValue) {
                    updated = updated + returnValue;
                    console.log(updated);
                });
            }
            res.send("[{\"ReturnValue\":" + updated + "}]");
        });

    }

I am sending in 4 lines of results and my console.log(updated) counts up as it should for each line, e.g 1,2,3,4

However the res.send result for updated is always 0.

Could anyone please explain why this is happening? My var updated is outside of my loop and this is getting updated correctly, however when the loop is finished it seems to get reset to 0?

returnValue == @@rowcount from the stored procedure

intentionally-left-nil · Accepted Answer · 2022-01-14 18:22:55Z

2

request is async so

res.send("[{\"ReturnValue\":" + updated + "}]");

gets executed even before you get the callback on request as JS doesn't wait for the callback and executes the next line. What you can do is use a counter and place your res.send inside for loop.

SendCompleted : function(req,res)
    {
        var updated = 0;
        var params = req.params.all();
        var dt = JSON.parse(decodeURI(params.id));
        var connection = new sql.Connection(testrmis, function (err)
        {
            if (err) {

            }
            var count = dt.length;
            for(var i = 0; i < dt.length; i++) {
                var obj = dt[i];
                var request = new sql.Request(connection);
                request.stream = true;
                request.input('branchid', sql.Int(), obj.branch_id);
                request.input('picklistid', sql.Int(), obj.picklist_id);
                request.input('scanned',sql.Int(),obj.scanned);
                request.input('expected', sql.Int(),obj.expected);
                request.input('poscode', sql.VarChar(),obj.poscode);
                request.input('label', sql.VarChar(), obj.label);
                request.input('dt', sql.VarChar(), obj.dt);
                request.execute('WAREHOUSE_InsertPiPackData');
                request.on('done', function(returnValue) {
                    count--;
                    updated = updated + returnValue;
                    console.log(updated);
                    if(count == 0) res.send("[{\"ReturnValue\":" + updated + "}]");
                });
            }
        });

    }

edited Jan 14, 2022 at 18:22

intentionally-left-nil

8,3858 gold badges41 silver badges62 bronze badges

answered Jun 5, 2015 at 10:53

Zee

8,4805 gold badges39 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

dave Over a year ago

Thank you, for the explanation and a good recommendation for a solution, exactly what I was after :-)

Subburaj · Accepted Answer · 2015-06-05 10:45:06Z

1

Try for this:

May be Async problem:

for(var i = 0; i < dt.length; i++) {    
//Your logic    
  if(i=== dt.length){
     res.send("[{\"ReturnValue\":" + updated + "}]");
  }    
}

answered Jun 5, 2015 at 10:45

Subburaj

5,21211 gold badges48 silver badges95 bronze badges

Comments

Abhishek Jain · Accepted Answer · 2015-06-05 10:51:29Z

1

This is because at the time you do request.send, the value of updated is not incremented. This is because request.execute is asynchronous and done handler will be invoked after the res.send has been executed.

I would recommend a promise library (example, q). You can combine the promises and then use Q.all to do req.send when all the promises are done.

See more details here

edited Jun 5, 2015 at 10:51

answered Jun 5, 2015 at 10:45

Abhishek Jain

2,97724 silver badges35 bronze badges

1 Comment

dave Over a year ago

Thanks for the suggestion, I can see the benefit of the library but feel it would be overkill in my case

Collectives™ on Stack Overflow

Variable from for loop always returns 0

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related