Finding minimum with a recursive function

Question

Whatever the input, the result is always 0. Why is that ?

#include <stdio.h>
#include <conio.h>

int rekursiv( int v[], int i, int n, int *min );

int main( void )
{
    int v[ 100 ];
    int n, i, min;

    printf( "Shkruanni n: " );
    scanf( "%d", &n );
    printf( "Shkruani elementet e vektorit.\n" );
    for( i = 0; i < n; i++ ){
         scanf( "%d", &v[ i ] );

         }//end for
    min = v[ 0 ];
    i = 1;
    printf( "Minimumi eshte %d.", rekursiv( v, i, n, &min ) );

    getche();
    return 0;
}//end main

int rekursiv( int v[], int i, int n, int *min )
{
    if( i == n - 1 ) {
        return *min;
    }//end if
    else {
        if( *min < v[ i ] ) {
            *min = v[ i ];
        }//end if
        rekursiv( v, i + 1, n, min );
    }//end else

}//end rekursiv

Perhaps you should include a small description of the code

Levi
– Levi

2015-06-18 08:19:45 +00:00
Commented Jun 18, 2015 at 8:19 — Levi
– Levi, Commented Jun 18, 2015 at 8:19
#include stdio.h #include conio.h? Where did the <> go?

Spikatrix
– Spikatrix

2015-06-18 08:31:27 +00:00
Commented Jun 18, 2015 at 8:31 — Spikatrix
– Spikatrix, Commented Jun 18, 2015 at 8:31
Why recursive? This is an overkill.

Mohit Jain
– Mohit Jain

2015-06-18 08:33:48 +00:00
Commented Jun 18, 2015 at 8:33 — Mohit Jain
– Mohit Jain, Commented Jun 18, 2015 at 8:33
Because it's homework :D

sweisgerber.dev
– sweisgerber.dev

2015-06-24 14:11:04 +00:00
Commented Jun 24, 2015 at 14:11 — sweisgerber.dev
– sweisgerber.dev, Commented Jun 24, 2015 at 14:11

The Dark · Accepted Answer · 2015-06-18 08:22:21Z

6

You should compile with warnings switched on. rekursiv does not always return a value.

Change

rekursiv( v, i + 1, n, min );

to

return rekursiv( v, i + 1, n, min );

answered Jun 18, 2015 at 8:22

The Dark

8,5041 gold badge18 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

meneldal Over a year ago

I'm pretty sure both msvc and gcc would give warnings on this with the default settings. I would assume he just didn't read them because everyone knows warnings are normal.

Khamill · Accepted Answer · 2015-06-18 08:30:51Z

0

In function (int rekursiv( int v[], int i, int n, int *min ) ), must be return integer so your last condition does not return anything. You should check last condition ELSE

else {
         if( *min < v[ i ] ){
             *min = v[ i ];

             }//end if
         rekursiv( v, i + 1, n, min );

         }

answered Jun 18, 2015 at 8:30

Khamill

517 bronze badges

Collectives™ on Stack Overflow

Finding minimum with a recursive function

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related