bash function - file names with spaces as arguments

Question

I have this bash function which takes files as arguments:

txz()
{
  file_in=${@:1:$#-1}
  file_out=${@: -1}

  echo "file_in=${file_in}"
  echo "file_out=${file_out}"

  tar -cvf - ${file_in} | xz -e9zf - > "${file_out}"
}

The function should be invoked with at least 2 arguments. The last argument is always archive name, the rest of arguments are files to compress. The function works as it should when i invoke it for files without spaces in their names like:

txz File1 File2 archive.tar.xz

But it fails whith:

txz "File 1" "File 2" archive.tar.xz

file_in=File 1 File 2
file_out=archive.tar.xz
tar: File: Cannot stat: No such file or directory
tar: 1: Cannot stat: No such file or directory
tar: File: Cannot stat: No such file or directory
tar: 2: Cannot stat: No such file or directory
tar: Exiting with failure status due to previous errors

I also tried creating an array, but it doesn't work either:

txz()
{
  file_in=(${@:1:$#-1})
  file_out=${@: -1}

  echo "file_in=${file_in[@]}"
  echo "file_out=${file_out}"

  tar -cvf - "${file_in[@]}" | xz -e9zf - > "${file_out}"
}

How should i create the function so it works for all file names?

anubhava · Accepted Answer · 2015-06-22 11:45:27Z

1

You should use BASH array to store multiple file names:

txz() { 
   file_in=( "${@:1:$#-1}" )
   file_out="${@: -1}"
   echo "file_in=${file_in[@]}"
   echo "file_out=${file_out}"

   tar -cvf - "${file_in[@]}" | xz -e9zf - > "${file_out}"
}

PS: Note how $@ must have double quoting in both assignments.

edited Jun 22, 2015 at 11:45

answered Jun 22, 2015 at 11:34

anubhava

790k67 gold badges603 silver badges671 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

bash function - file names with spaces as arguments

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related