Loop iterates through array too many times Java

Question

so I am working on a java project that will order Items. However in my code, which is supposed to iterate through some tokenized terms and assign them to values in a custom Items class seems to not be working.
Code:

public void tokenizeTerms(String content) {
        String[] tokenizedTerms = content.split(" ");
        Item[] itemArray = new Item[tokenizedTerms.length/3];
        Item fillItem = new Item();
        fillItem.setName("fillItem");
        fillItem.setPrice(0.00);
        fillItem.setQuantity(1);
        Arrays.fill(itemArray, fillItem);
        int currToken = 0;
        for(int i = 0; i < itemArray.length; i++) {
            itemArray[i].setName(tokenizedTerms[currToken]);
            currToken++;
            try {
                int foo = Integer.parseInt(tokenizedTerms[currToken]);
                itemArray[i].setQuantity(foo);
                currToken++;
                double moo = Double.parseDouble(tokenizedTerms[currToken]);
                itemArray[i].setPrice(moo);
                currToken++;
            } catch (Exception e) {
                System.out.println("Error parsing data.");
            }

        }
        this.items = itemArray;
    }

Item Class:

public class Item {
    private String name;
    private int quantity;
    private double price;

    public void setName (String name) {
        this.name = name;
    }
    public String getName () {
        return this.name;
    }
    public void setQuantity (int quantity) {
        this.quantity = quantity;
    }
    public int getQuantity () {
        return this.quantity;
    }
    public void setPrice (double price) {
        this.price = price;
    }
    public double getPrice () {
        return this.price;
    }
}

When I run though the tokenize terms method and print the values of each item in itemArray I get a set of items that look like this.
Name: Book Quantity: 14 Price: 856.89
Name: Book Quantity: 14 Price: 856.89
Name: Book Quantity: 14 Price: 856.89
However I know this should not be happening since the String[] tokenizedTerms looks like this:

[CD, 32, 459.2, T-Shirt, 22, 650.8, Book, 14, 856.89]

Eran · Accepted Answer · 2015-07-05 05:12:26Z

5

The problem is with your initialization of the array. You put multiple references to the same Item instance in your array :

    Item fillItem = new Item();
    ...
    Arrays.fill(itemArray, fillItem);

You should put different Item instances in each index of the array:

for(int i = 0; i < itemArray.length; i++) {
    itemArray[i] = new Item ();
}

edited Jul 5, 2015 at 5:12

answered Jul 5, 2015 at 5:10

Eran

395k57 gold badges726 silver badges793 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Will Fisher Over a year ago

I only did that to fill the array so that further down the road I could call the setters without getting a nullreferenceexception

Eran Over a year ago

@WillFisher But that's a wrong initialization. It means that all the setter calls update the same Item instance. That's why you see the same values in all the indices of the array.

Will Fisher Over a year ago

I figured out what you meant, got it working. Cant believe that stumped me for so long... Thanks! Ill accept answer when I can

Collectives™ on Stack Overflow

Loop iterates through array too many times Java

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related