How to improve loop Xdocument

Question

I'm doing an example about how to read with c# and linq an .xml file, I read it but I think that the code is not good.

Any suggestion, or explanation how to do better is welcome.

XML:

<file>
 <order>
  <products>
    <product>
     <id>123</id>
     <Description>Camera</Description>
     <seller>Website</seller>
    </product>
    <product></product>
    <product></product>
  </products>
 </order>
</file>

And this is my code, I want to improve the part to take the description, this way doesn't looks nice.

var reader = XDocument.Load("file.xml");
var listProdcutsNodes = reader.Element("file").Element("order").Element("products").Elements("product").Select(input => input.Elements()).ToList();
var description = "";
foreach (var listProdcutsNode in listProdcutsNodes)
{
    var isproduct = false;
    foreach (var xElement in listProdcutsNode)
    {
        if (xElement.Name == "id" && xElement.Value == "123")
        {
            isproduct = true;
        }

        if (isproduct && xElement.Name == "Description")
        {
            description = xElement.Value;

        }

    }

    isproduct = false;
}

Not quite sure what are you trying to achieve. Is is just "how to get description of product having some specified id"? — Andrey Korneyev
– Andrey Korneyev, Commented Jul 7, 2015 at 11:18

Andrey Korneyev · Accepted Answer · 2015-07-07 11:21:55Z

1

Getting all of nodes as list and iterating over them is redundant in your case.

You can get that description pretty easily like this:

string myID = "123";
var description = reader.XPathSelectElements("/file/order/products/product")
                .Where(x => x.Element("id").Value == myID)
                .Select(x => x.Element("Description").Value).FirstOrDefault();

answered Jul 7, 2015 at 11:21

Andrey Korneyev

26.9k16 gold badges73 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kram · Accepted Answer · 2015-07-07 11:27:24Z

1

You can use Linq, Or Just regular XPath. This is the xpath for your xml :

//product[./*[text()='123']]/Description/text()

answered Jul 7, 2015 at 11:27

Kram

5265 silver badges12 bronze badges

Collectives™ on Stack Overflow

How to improve loop Xdocument

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related