How to use the same variable in two different jQuery events?

Question

I am working on a rating system and want to pull up each rating value by the jquery. For this purpose I am doing like this, but I am unable to get previous event variable value into next event.

var r1Rating;
    $(".rating-input").on("click",function(){
        //alert($(this).attr("id"));

        var r1=$(this).attr("id");
        var r1Array=r1.split("-");
        //alert(r1Array[r1Array.length-1]);
        var r1Rating=parseInt(r1Array[r1Array.length-1]).toFixed(2);
        $("#total_rating").html(r1Rating);
        var r1Rating=r1Rating;
    });

$(".rating-input1").on("click",function(){
        alert(r1Rating); //I want to get value here
});

Any help, suggestion would be appreciated. Thanks

you are creating r1Rating again in your function. remove the var — atmd
– atmd, Commented Jul 9, 2015 at 8:00
Do r1Rating=parseInt(r1Array[r1Array.length-1]).toFixed(2); (without the var), and remove the last line of your first function (var r1rating = ..) — putvande
– putvande, Commented Jul 9, 2015 at 8:00
don't declare new variable r1Rating inside the first click event listener (remove var keyword), and you will be able to use the one defined in the outer scope (first line) — Hacketo
– Hacketo, Commented Jul 9, 2015 at 8:00
See regarding variable's scope: stackoverflow.com/questions/500431/… That's said, if you provide relevant HTML markup, it should be better way to do it — A. Wolff
– A. Wolff, Commented Jul 9, 2015 at 8:01

Arun P Johny · Accepted Answer · 2015-07-09 08:01:56Z

4

Even though you have a r1Rating in the external scope, since you are using var r1Rating in the click handler, you are creating a new locally scoped variable in the click handler. So any changes you make to the variable will be visible inside that method only and the variable in the external scope will not be updated.

var r1Rating;
$(".rating-input").on("click", function () {
    //alert($(this).attr("id"));

    var r1 = $(this).attr("id");
    var r1Array = r1.split("-");

    //should not use var here
    r1Rating = parseInt(r1Array[r1Array.length - 1]).toFixed(2);
    $("#total_rating").html(r1Rating);
});

$(".rating-input1").on("click", function () {
    alert(r1Rating); //I want to get value here
});

edited Jul 9, 2015 at 8:01

answered Jul 9, 2015 at 8:00

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

KiiroSora09 · Accepted Answer · 2015-07-09 08:01:23Z

-2

The code below should be changes, since in this instance, you created a new r1Rating variable in a scope, which means that this was a different variable from the global one outside.

var r1Rating=r1Rating;

This should be changed to:

r1Rating=r1Rating;

answered Jul 9, 2015 at 8:01

KiiroSora09

2,28718 silver badges22 bronze badges

4 Comments

A. Wolff Over a year ago

OP is declaring r1Rating twice. I know, doesn't really make sense

Hacketo Over a year ago

this answer does not make sense too

A. Wolff Over a year ago

@Hacketo It would make sense if OP wasn't declaring same variable twice. EDIT: in fact, he's declaring it three times

Hacketo Over a year ago

@A.Wolff assigning a variable to itself ? It make sense for you ?

Collectives™ on Stack Overflow

How to use the same variable in two different jQuery events?

2 Answers 2

Comments

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related