Rails not registering API call variable

Question

I have a simple API called wrapped in my lib/

lib/riotapi.rb

class RiotApi
    riot_url = 'https://na.api.pvp.net/api/lol/na/v1.4/summoner/by-name/RiotSchmick?api_key=ENV['mykey']'

    def unique_url
        response = HTTParty.get(riot_url)
        json = JSON.parse(response.body)
        json
    end
end

my controller

class WelcomeController < ApplicationController

    require 'riotapi'

    def index
        api = RiotApi.new()
        @list = api.unique_url
    end
end

I have my welcome#index as the index page of the application. When I open it up, it says that undefined local variable or method "riot_url"

What am I doing wrong here?

Edit: The above sample is taken from here Very Basic Rails 4.1 API Call using HTTParty

Take a look at the syntax highlighting in your first block. Did you copy/paste that in? Seems like you are missing a ' — jkeuhlen
– jkeuhlen, Commented Jul 14, 2015 at 21:38
sorry that was typo on my part, the syntax is all good as far as I checked! — user3277633
– user3277633, Commented Jul 14, 2015 at 21:40
@AbM interesting, that seem to did the trick! If you'd like to answer this question, I would love to accept your solution. — user3277633
– user3277633, Commented Jul 14, 2015 at 21:45

Community · Accepted Answer · 2017-05-23 11:58:17Z

1

You should use a ruby constant (ALL CAPITAL) for this:

lib/riotapi.rb

class RiotApi
    RIOT_URL = 'https://na.api.pvp.net/api/lol/na/v1.4/summoner/by-name/RiotSchmick?api_key=ENV['mykey']'

    def unique_url
        response = HTTParty.get(RIOT_URL)
        JSON.parse(response.body)
    end
end

Also note that you do not have to use the json variable in your unique_url

Here's is a SO answer that goes over the variable scope in a class. Note that I chose a ruby constant since I assumed the url will not changed. If you have a method in your class that changes the url, you should use a class variable (the one with @@)

edited May 23, 2017 at 11:58

CommunityBot

11 silver badge

answered Jul 14, 2015 at 21:47

AbM

7,8192 gold badges30 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

jkeuhlen Over a year ago

Could you add an explanation as to the difference between riot_url and RIOT_URL?

Collectives™ on Stack Overflow

Rails not registering API call variable

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related