Change image view source based on the value from database in custom listview

Question

In my android application I have a custom listview (ArrayAdapter). in its getView() method there is a TextView and an Imageview, ImageView is for marking and un-marking favorite. When the application loads first time it checks in database if its id is available in the favorite table, if it there its image changes, but my problem is it marked favorite for non-favorite item. I am pasting my code below

      @Override
            public View getView(final int position, View convertView, ViewGroup parent) {
                View view = convertView;
                if (view == null) {
                    view = getActivity().getLayoutInflater().inflate(R.layout.custom_list_item, parent, false);
                }
                Item item = ItemList.get(position);
                TextView title = (TextView) view.findViewById(R.id.title);

                ImageView favorite = (ImageView) view.findViewById(R.id.favourite_mark_icon);
                if (mHandler.checkForIDMatchForFav(item)) {
                    favorite.setImageResource(R.drawable.fav_marked);
                }
 favorite.setOnClickListener(new View.OnClickListener() {
                @Override
                public void onClick(View v) {
                    markFavourite(position, v);
                }
            });

                return view;
            }

any help is appreciated.

GVillani82 · Accepted Answer · 2015-07-15 10:29:20Z

1

Since you are reusing the view, getting the parameter convertView, you need to change each view state before generate the new view. Recycling allow you to base your new view on a template (the old view) but you should change it if the content are dynamic

Simply add an else branch, where the favorite ImageView is setted to the default non marked icon.

if (mHandler.checkForIDMatchForFav(item)) {
    favorite.setImageResource(R.drawable.fav_marked);
}else{
    favorite.setImageResource(R.drawable.not_marked);
}

edited Jul 15, 2015 at 10:29

answered Jul 15, 2015 at 10:26

GVillani82

17.4k32 gold badges110 silver badges177 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Amsheer · Accepted Answer · 2015-07-15 10:32:18Z

I note that few mistakes in this code. While recycling your code will break. Try the following

@Override
            public View getView(final int position, View convertView, ViewGroup parent) {
                View view = convertView;
ViewHolder holder;
                if (view == null) {
holder = new ViewHolder()
                    view = getActivity().getLayoutInflater().inflate(R.layout.custom_list_item, parent, false);
holder .title = (TextView) view.findViewById(R.id.title);

               holder. favorite = (ImageView) view.findViewById(R.id.favourite_mark_icon);
view.setTag(holder);
                }else{
holder = (ViewHolder) view.getTag();
}
                Item item = ItemList.get(position);

                if (mHandler.checkForIDMatchForFav(item)) {
                    holder.favorite.setImageResource(R.drawable.fav_marked);
                }else{
//set here your image 
}
 holder.favorite.setOnClickListener(new View.OnClickListener() {
                @Override
                public void onClick(View v) {
                    markFavourite(position, v);
                }
            });

                return view;
            }

class ViewHolder{
TextView title;
ImageView favorite;
}

You must handle else condition for the following .

 if (mHandler.checkForIDMatchForFav(item)) {

Collectives™ on Stack Overflow

Change image view source based on the value from database in custom listview

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related