How to store values in single dimensional character pointer array

Question

I want store values into a character pointer pointer.I have worked out a code which is mentioned below:

#include<string.h>
#include<stdlib.h>
#include<stdio.h>

int i=0,j,n,no_stops;
char *r[10],*s[10][10];
char *a,*b;


void fetch_routes_stops()
   {
   printf("Enter the no of routes:");
   scanf("%d",&n);
   for(i=0;i<n;i++)
   {
       printf("\nEnter the route No %d:",i+1);
       scanf("%s",&a);
       r[i]=strdup(a);
   }
}

void main()
{
    fetch_routes_stops();
    for(i=0;i<n;i++)
    {
        printf("\n%s",r[i]);
    }
}

void main() --> int main(void)

Sourav Ghosh
– Sourav Ghosh

2015-07-15 13:30:19 +00:00
Commented Jul 15, 2015 at 13:30 — Sourav Ghosh
– Sourav Ghosh, Commented Jul 15, 2015 at 13:30
What are you trying to do?

Lawrence Aiello
– Lawrence Aiello

2015-07-15 13:31:00 +00:00
Commented Jul 15, 2015 at 13:31 — Lawrence Aiello
– Lawrence Aiello, Commented Jul 15, 2015 at 13:31
Pick one of C++ and C, they are different languages.

TartanLlama
– TartanLlama

2015-07-15 13:35:36 +00:00
Commented Jul 15, 2015 at 13:35 — TartanLlama
– TartanLlama, Commented Jul 15, 2015 at 13:35
c will be preferable

Mahesh Ayyappan
– Mahesh Ayyappan

2015-07-17 04:22:16 +00:00
Commented Jul 17, 2015 at 4:22 — Mahesh Ayyappan
– Mahesh Ayyappan, Commented Jul 17, 2015 at 4:22

Sourav Ghosh · Accepted Answer · 2015-07-15 13:49:46Z

1

In your code,

 scanf("%s",&a);

is wrong, as a is uninitialised, and &a is not the argument you would need to pass. You need to allocate enough memory to a before passing that.

Better, you don't need to have a pointer for that itself. You can chnage your code like

  char a[128];

and then, use

  scanf("%127s", a);    //limit the input against overflow

to take the user input.

Or, if you insist to use the pointer and want to go for dynamic memory allocation, you can have a look at malloc() and family of functions. Remember, in that case also, you pass a to scanf(), not &a.

After that, please note

The recommended signature of main() is int main(void).
Do not use unnecessary global variables. You can always pass the variables as function parameters to use them across functions.

edited Jul 15, 2015 at 13:49

answered Jul 15, 2015 at 13:31

Sourav Ghosh

135k17 gold badges192 silver badges271 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to store values in single dimensional character pointer array

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related