On Item Click Listener for List View extending ArrayAdapter

Question

What I have tried:

public class EntryAdapter extends ArrayAdapter<Item> {

private Context context;
private ArrayList<Item> items;
private LayoutInflater vi;

public EntryAdapter(Context context,ArrayList<Item> items) {
    super(context,0, items);
    this.context = context;
    this.items = items;
    vi = (LayoutInflater)context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
}

@Override
public View getView(int position, final View convertView, ViewGroup parent) {

    // // // //  NON-FUNCTIONING CODE BELOW 

    AdapterView.OnItemClickListener listener = new AdapterView.OnItemClickListener() {

        @Override
        public void onItemClick(AdapterView<?> parent, View view, int position, long id) {

            Intent intent = new Intent(getContext(), NewsItemActivity.class);
            convertView.getContext().startActivity(intent);

        }
    };
}

The AdapterView.onItemClickListener doesnt yield any errors but doesnt seem to function whatsoever.

What is the proper way of setting this onClick Listener?

Note: I have to set it in this adapter class, not the main class for my own reasons.

Can you expand please. convertView.setOnItemClickListener ? — Greg Peckory
– Greg Peckory, Commented Jul 15, 2015 at 13:35
convertView.setOnClickListener doesnt give any errors except I cant seem to run the line startActivity(intent). Any ideas? — Greg Peckory
– Greg Peckory, Commented Jul 15, 2015 at 13:39
Try using the context initialized in the adapter constructor — Chol
– Chol, Commented Jul 15, 2015 at 13:42

GVillani82 · Accepted Answer · 2015-07-15 13:48:32Z

2

You shuldn't implement a listener inside the getView() unless you what set a listener on a particular view inside your row layout.

You should instead use setOnItemClickListener() method on your ListView:

ListView lv = (ListView) findViewById(R.id.your_listview);
lv.setOnItemClickListener(new AdapterView.OnItemClickListener() {
     @Override
     public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
         Intent intent = new Intent(context, NewsItemActivity.class);
         context.startActivity(intent);
     } 
});

EDIT:

If, for each action inside the onclick, you need information that resides in your Objects (Item) then you can get it in this way:

Item item = (Item)listview.getAdapter().getItem(position);

from inside of onItemClick() method

edited Jul 15, 2015 at 13:48

answered Jul 15, 2015 at 13:42

GVillani82

17.4k32 gold badges110 silver badges177 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

Greg Peckory Over a year ago

I have methods running inside my adapter class which returns values I need to pass through the intent. Hence the onClickListener in the adapter class

Vishwa Over a year ago

You can also get the selected content in OnItemClickListener itself by using adapterView.getItemAtPosition(position).

GVillani82 Over a year ago

Yes, you can use getItem(position) or getItemAtPosition(position). Basically getItemAtPosition(position) calls the adapter with getItem(position).

Greg Peckory Over a year ago

What's the difference between Item item = (Item) listview.getAdapter().getItem(position); and Item item = listArray.get(position) where listArray is the array I pass into my adapter

GVillani82 Over a year ago

Also if there is not relevant different, I always prefer the first one. If you mantain an external reference to the list inside the adapter you can cause problem. Or if your list is accidentally set to null, you lost your reference, but your list still exsists inside the adapter.

|

Chol · Accepted Answer · 2015-07-15 13:41:10Z

0

You can use:

convertView.setOnClickListener(new View.OnClickListener() {

        @Override
        public void onClick(View v) {
            //Make what you want
        }
    });

Or depending on your item view, you can make the OnCLickListener on your global layout of the item or a specific item's layout

answered Jul 15, 2015 at 13:41

Chol

2,1172 gold badges18 silver badges28 bronze badges

4 Comments

Greg Peckory Over a year ago

Cannot resolve startActivity. Other than this it seems to be giving no problems

Chol Over a year ago

Try with context.startActivity()

Greg Peckory Over a year ago

It gets rid of the error message, but the app crashes on start-up now

Chol Over a year ago

check for null on convertView

Amitsharma · Accepted Answer · 2015-07-15 13:46:48Z

0

Try by this code :-

Spinner cb_tv;
ArrayList<String> list = new ArrayList<String>();
ArrayAdapter<String> dataAdapter;
list.add(phone1);
list.add(name1);
dataAdapter = new ArrayAdapter<String>(Display_Tank.this,android.R.layout.simple_spinner_item, list);
cb_tv.setAdapter(dataAdapter);

cb_tv.setOnItemClickListener(new OnItemClickListener() {

        @Override
        public void onItemClick(AdapterView<?> arg0, View arg1, int arg2,
                long arg3) {
            // TODO Auto-generated method stub  
            Toast.makeText(getApplicationContext(),"Clicked",Toast.LENGTH_SHORT).show();
        }
    });

at the place of cb_tv Spinner You can use ListView

answered Jul 15, 2015 at 13:46

Amitsharma

1,5661 gold badge17 silver badges29 bronze badges

Comments

slorangex · Accepted Answer · 2015-07-15 14:18:08Z

0

First of all, the best way to achieve this is to use your own ViewHolders in ListView.

This is an example of a custom ViewHolder

class MyViewHolder extends ViewHolder implements View.OnItemClickListener {
    public MyViewHolder(View view) {
        /* Implement your views here
         * like this: mTextView = (TextView) view.findViewById(R.id.myId);
         */
         view.setOnItemClickListener(this);
    }

    @Override
        public void onClick(View view) {
            Intent intent = new Intent(getContext(), NewsItemActivity.class);
            convertView.getContext().startActivity(intent);
        }
    }

And on your getView method you create this ViewHolder and populate your Views with your data.

answered Jul 15, 2015 at 14:18

slorangex

1,3942 gold badges12 silver badges26 bronze badges

Comments

Anil Meenugu · Accepted Answer · 2015-07-15 14:49:05Z

0

You can try this way... it is working in my case Change your context to
Activity activity = (Activity) context;

       convertView.setOnClickListener(new View.OnClickListener() {

        @Override
        public void onClick(View v) {
             Intent intent = new Intent(activity, NewsItemActivity.class);
             activity.startActivity(intent);

        }
    });

edited Jul 15, 2015 at 14:49

Anil Meenugu

1,4312 gold badges11 silver badges16 bronze badges

answered Jul 15, 2015 at 14:06

MPG

7956 silver badges21 bronze badges

3 Comments

Greg Peckory Over a year ago

had to declare final... still app crashes on launch though

MPG Over a year ago

you can direct change it from your constructor in place of context it change to activity variable/instance and typecast this.

MPG Over a year ago

private Context context; is replace with private Activity context; and this.context = context; is replace with this.context = (Activity)context;

Collectives™ on Stack Overflow

On Item Click Listener for List View extending ArrayAdapter

5 Answers 5

10 Comments

4 Comments

Comments

Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

10 Comments

4 Comments

Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related