PHP script to create file if no exist

Question

I have a small problem with my php code. Please take a look:

<?php
$urlud = $json['url'];
$content = 'Content 1 if file no exist will generate';
$filename = $json['id'].".html";
if (file_exists($filename)) {
    echo "File exists!";
} else {
    file_put_contents('dir1/'. $filename, $content, FILE_APPEND | LOCK_EX);
}
?>
<?php
$urlud = $json['url'];
$content = 'Content 2 if file no exist will generate';
$filename = $json['id'].".html";
if (file_exists($filename)) {
    echo "File exists!";
} else {
    file_put_contents('dir2/'. $filename, $content, FILE_APPEND | LOCK_EX);
}
?>

This code will generate 2 files in different directories with different content. My problem is:

This code keeps replacing my old file content. Any solution to make it create only if the file doesn't exist ?
Any other input to make this code simpler?

Thanks.

maybe since you are writing to dir2 you ahould also be checking for the file there — Orangepill
– Orangepill, Commented Jul 18, 2015 at 3:45
another solution, use php randon string function and add it with file name so you will have $filename $string and $string will be unique everytime — Shehary
– Shehary, Commented Jul 18, 2015 at 3:52
i'm still unable to do that.. already change dir2 function to different call like $filename2 and still have same problem.. — Lorenz
– Lorenz, Commented Jul 18, 2015 at 3:55

Harald Doderer · Accepted Answer · 2015-07-18 04:00:02Z

2

if (file_exists('dir1/'. $filename))

and

if (file_exists('dir2/'. $filename))

You have to check the full path of the file not only the file name. E.g. imagine $filename to be "readme.txt" This file is probably not existing in your script path. And you expect it to be in dir1 or dir2.

answered Jul 18, 2015 at 4:00

Harald Doderer

1085 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Lorenz Over a year ago

hi @Harald Doderer, thanks for your solution.. this work like i want.. old file keep on there and not replacing with new one..

Collectives™ on Stack Overflow

PHP script to create file if no exist

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related